Inline Lyrics 3.2 - Updated 29/07/2014

Post a reply

Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:
BBCode is ON
[img] is ON
[url] is ON
Smilies are ON
Topic review
   

Expand view Topic review: Inline Lyrics 3.2 - Updated 29/07/2014

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by Ria8 » Sat Oct 29, 2016 10:41 am

Hi!
I love this add very much but I have songs that are in my native language (which is not a common one) and the add doesn't find lyrics to those. Is there a way for this add to get lyrics for these songs from a lyrics webpage from my country. Can I set that somehow? Or does anyone have an idea with which add can I do that? For the add to see lyircs from a spesific webpage?

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by crap_inhuman » Wed Feb 04, 2015 7:35 pm

dolf-volkoff wrote:
trixmoto wrote:They have to be in the right format for it to work properly. Any particular errors?
Now that veroK mentioned it, I recall that there was an issue with blank lines in the lyrics. I used to copy timestamped lyrics from MiniLyrics editor and there sometimes was an extra blank line at the end that I didn't notice. It caused some kind of an error, but I don't remember what it said. Now I always check for that and remove blank lines, so the issue doesn't occur to me anymore.

But I think it would be better if the add-on didn't react on things like that with errors, as there might be instances, where the user didn't notice an extra blank line, doesn't want the lyrics for a particular song to be timestamped at all, or wants to add /*comments*/ to lyrics, that must only appear in editor.

I think it would be best if the add-on just skipped blank lines and lines without timestamps not showing any kind of notice, and just focused on timestamped lines.
Hi trixmoto,

if you change the function getline in your script with the following code, you can bypass the problem with blank lines in the lyrics.

Code: Select all

Function getline(txt)
  If txt <> "" Then
    getline = Mid(txt,11,Len(txt)-10)
  Else
    getline = ""
  End If
End Function
I stumble over the error messages while playing with your add-on. First i thought it was a bad lyrics file, but then i found the blank line post from dolf-volkoff

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by trixmoto » Tue Aug 26, 2014 2:44 pm

Ok, thanks. I'll take a look when I get a chance.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by veroK » Tue Aug 26, 2014 10:05 am

dolf-volkoff wrote:
trixmoto wrote:They have to be in the right format for it to work properly.
WHAT format world that be?
trixmoto wrote:
Any particular errors?
See image below for the errors that pop-up.


Image

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by trixmoto » Mon Aug 25, 2014 4:32 am

I think the script should ignore any line that doesn't start with "[", but I'll double check it.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by dolf-volkoff » Mon Aug 25, 2014 2:31 am

trixmoto wrote:They have to be in the right format for it to work properly. Any particular errors?
Now that veroK mentioned it, I recall that there was an issue with blank lines in the lyrics. I used to copy timestamped lyrics from MiniLyrics editor and there sometimes was an extra blank line at the end that I didn't notice. It caused some kind of an error, but I don't remember what it said. Now I always check for that and remove blank lines, so the issue doesn't occur to me anymore.

But I think it would be better if the add-on didn't react on things like that with errors, as there might be instances, where the user didn't notice an extra blank line, doesn't want the lyrics for a particular song to be timestamped at all, or wants to add /*comments*/ to lyrics, that must only appear in editor.

I think it would be best if the add-on just skipped blank lines and lines without timestamps not showing any kind of notice, and just focused on timestamped lines.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by trixmoto » Sun Aug 24, 2014 3:37 pm

They have to be in the right format for it to work properly. Any particular errors?

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by veroK » Fri Aug 22, 2014 12:03 pm

It worked for me for a couple of songs that had lyrics on evilyrics. The one track I tried that didn't, gave me all kind of errors. Then I tried to ADD a timestamp line to a song and it crashed pretty spectacularly.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by trixmoto » Thu Jul 31, 2014 11:03 am

Hmm, that's odd. I'll have to try and replicate.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by dolf-volkoff » Wed Jul 30, 2014 8:41 am

Thanks! The fix works great.

But you really need to do something about this line:

Code: Select all

Call SDB.MessageBox("InlineLyrics: The progress bar has been lost",mtError,Array(mbOk))
It seems to cause this error when you start song after song from Windows Explorer:

Code: Select all

InlineLyrics: The progress bar has been lost
It might have something to do with switching between songs that have lyrics in them and songs that don't, but it's not entirely clear, so it might be random.

And it seems to cause this error when you start song after song from Mediamonkey's Now Playing:

Code: Select all

Error executing script event.
Access violation at address 009A6D4E in module "MediaMonkey.exe". Read of address 17FD07AB.
Removing the line entirely seems to fix both errors without any side effects.

Re: Inline Lyrics 3.2 - Updated 29/07/2014

by trixmoto » Tue Jul 29, 2014 4:19 pm

New version (3.2) is now available to download from my website. I have fixed the sync delay when seeking in a track.

Re: Inline Lyrics 3.1 - Updated 24/03/2009

by dolf-volkoff » Sun Apr 06, 2014 1:23 am

Well, in that case, maybe instead of being a different plugin, the editor should open in some kind of "Editing mode" of the lyrics plugin. That way it will take the same space as the lyrics plugin (or maybe open in a non-dockable window which would close after user finished editing), which is very relevant as we don't have this functionality yet.

Re: Inline Lyrics 3.1 - Updated 24/03/2009

by trixmoto » Sat Apr 05, 2014 4:19 am

Unfortunately it's not possible to change the way the built-in lyrics editor works, it would have to be a separate dockable panel for it to be done by scripting.

Re: Inline Lyrics 3.1 - Updated 24/03/2009

by dolf-volkoff » Fri Apr 04, 2014 12:12 pm

trixmoto wrote:I think this would probably be a separate script, or at least a very different mode, as it would be a totally different way of displaying the lyrics. But I'll add it to my list.
I'll be keeping my eyes for the news :D
trixmoto wrote:I also used to have a "Lyric Timer" script that was a dockable panel and made it easier to create timed lyrics, but it's never worked in MM4.
Yes, I tried that one. The first version of Mediamonkey I tried it with was 4.0.6 or 4.0.7, so... yeah, it didn't quite work. I like the idea, but I don't think a dockable panel is the best choice for lyrics editor, as the editor needs as much space it can get.

What I have in mind is more of a modification of the standard lyrics editing field in Mediamonkey. I'm not sure if it's doable through scripting, but, if there was a way to replicate MiniLyrics' "Lyrics editor" controls and attach them to Mediamonkey's lyrics editing field, we could easily get rid of MiniLyrics altogether.

Right now I'm using MiniLyrics' "Lyrics editor" to synchronize the lyrics, and then copy&paste it to files properties' Lyrics field, which, as you can imagine, isn't the most comfortable way of doing it. A plugin that can save me from this would be very welcome :)

Re: Inline Lyrics 3.1 - Updated 24/03/2009

by trixmoto » Fri Apr 04, 2014 7:52 am

I think this would probably be a separate script, or at least a very different mode, as it would be a totally different way of displaying the lyrics. But I'll add it to my list.

I also used to have a "Lyric Timer" script that was a dockable panel and made it easier to create timed lyrics, but it's never worked in MM4.

Top