Lyricator v1.4.1 (2018-4-23)

Post a reply


In an effort to prevent automatic submissions, we require that you complete the following challenge.
Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:

BBCode is ON
[img] is ON
[flash] is OFF
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: Lyricator v1.4.1 (2018-4-23)

Re: Lyricator v1.4.1 (2018-4-23)

by gibbon » Sun May 06, 2018 5:07 am

Brute Force attempts for Artist:
In the options for the brute force attempts is a delimter array which also contains "and" as delimiter.
This causes separate searches for anything that is in front of "and" and behind.

I noticed that with artists like "Wanda" or "Bobby Bland" or "Franz Ferdinand" the "and" in these names also causes a speparate search, which causes addtional time and certainly is not intended.

Changing "and" to " and " in the options repaired this for me.

Re: Lyricator v1.4.1 (2018-4-23)

by gibbon » Sun May 06, 2018 4:04 am

Guest wrote:Since the update the majority of sites now double space each lyric line, but apart from the addition of musixmatch and correcting metrolyrics there doesn't seem to be any real difference between the new and old lyricator.js files. Has there been any other changes?
I far from really understanding this code but I had a look at the differences between the former version and the new version.
I noticed a difference in line 496:

Code: Select all

l = l.replace(/\r?\n/g, '<br>');        // End of Line
The old version was without this question mark:

Code: Select all

 l = l.replace(/\r\n/g, '<br>');        // End of Line
I removed the question mark and at the moment I have no additional CRs.

Re: Lyricator v1.4.1 (2018-4-23)

by Guest » Sat May 05, 2018 1:05 pm

Hi,

I installed everything new (media monkey and Add-on) and and still got this error message when i try to search for lyrics "SDB.Tools.WebSearch.NewTracks" didn't find anything in the forum or the google. I hope maybe i can get answers this way.

Re: Lyricator v1.4.1 (2018-4-23)

by Guest » Wed Apr 25, 2018 8:14 am

Since the update the majority of sites now double space each lyric line, but apart from the addition of musixmatch and correcting metrolyrics there doesn't seem to be any real difference between the new and old lyricator.js files. Has there been any other changes?

Re: Lyricator v1.3.5 (2017-4-8)

by thehammer » Mon Apr 23, 2018 9:54 pm

thehammer wrote:
gibbon wrote:Since some days I get "Related" as a result from Metrolyrics if Metrolyrics has no lyrics for this song.
I think the script needs some changes to give no results for these cases again.
I finally have a bit of time to look into this, and have a fix. I am now having issues updating the plugin on HappyMonkeying and have to get some help with that.
This has been fixed with another issue fixed and I added Musixmatch as a lyrics lookup site

Re: Lyricator v1.3.5 (2017-4-8)

by thehammer » Sun Apr 22, 2018 9:29 am

Morbeas wrote:Ok but why would it duplicate tags that are already in the file? I mean this sounds exactly like a bug. Is this working as intended? Just wanted to post two screenshots (before and after) to demonstrate my point.

These are my tags before MM:
Image

And these are my tags after MM:
Image

I mean just the YEAR tag alone. Why would it be ok to duplicate that? I'm just trying to understand the logic, that's all.
This might get better attention in a MM main thread as it is not an issue with the Lyricator plugin.

Re: Lyricator script Question

by thehammer » Sat Apr 21, 2018 7:07 pm

rad wrote:I just got lyricator today due to Amazons changes, I finally got it to work and am wondering if it is possible to remove the stuff at the bottom of the lyrics, aka...

Lyrics provided by: letras.mus.br
Artist: Ani DiFranco
Track: Evolve

To me, its not worth auto tagging lyrics if I have to go into each one to remove those line.

Thanks,
RAD
I have had this request in the past, and my answer has been to leave them there when I am able to gather that information. If someone selects a bunch of songs at once and lets Lyricator run and doesn't review all the lyrics that were found, it is almost impossible to get back to me later when one of the sites has changed and is causing issues with the results. Also, the intention with the original authors of this plugin was to give the lyrics sites credit where credit is due for providing this valuable information.

I will think about putting this as an option in a next release, but have it on by default.

Re: Lyricator v1.3.5 (2017-4-8)

by thehammer » Sat Apr 21, 2018 7:03 pm

gibbon wrote:Meanwhile Letras brings a a lot of wrong results.
It is a good source for a lot of songs but the search is much too tolerant.

For instance:
Looking for the Song "Sarah Beatty - Autumn's Song" Letras gives the result:
Artist: Sarah's Redemption
Track: Autumn

or "Sarah Beatty - Dig Before You Sow" gives:
Artist: Sarah Jaffe
Track: Before You Go

Maybe there is a way to influence this tolerance in the direction of more exactness and looking for the exact artist and title?
Unfortunately, I haven't found a way to do that. That is the main reason I picked red for those results and also why the artist and title returned are displayed under the track entries.

Re: Lyricator v1.3.5 (2017-4-8)

by thehammer » Sat Apr 21, 2018 7:00 pm

gibbon wrote:Since some days I get "Related" as a result from Metrolyrics if Metrolyrics has no lyrics for this song.
I think the script needs some changes to give no results for these cases again.
I finally have a bit of time to look into this, and have a fix. I am now having issues updating the plugin on HappyMonkeying and have to get some help with that.

Re: Lyricator v1.3.5 (2017-4-8)

by Morbeas » Sat Apr 21, 2018 2:23 pm

Ok but why would it duplicate tags that are already in the file? I mean this sounds exactly like a bug. Is this working as intended? Just wanted to post two screenshots (before and after) to demonstrate my point.

These are my tags before MM:
Image

And these are my tags after MM:
Image

I mean just the YEAR tag alone. Why would it be ok to duplicate that? I'm just trying to understand the logic, that's all.

Re: Lyricator v1.3.5 (2017-4-8)

by Lowlander » Sat Apr 21, 2018 11:23 am

No, it can't be disabled, unless you set it to not write tags to the files at all (Tools > Options > Tags & Playlists).

Re: Lyricator v1.3.5 (2017-4-8)

by Morbeas » Sat Apr 21, 2018 8:21 am

Lowlander wrote:MediaMonkey writes those tags. Anytime any tag is changed all tags are written.
Oh ok, why is that even a thing and can it be disabled?

Re: Lyricator v1.3.5 (2017-4-8)

by Lowlander » Sat Apr 21, 2018 12:32 am

MediaMonkey writes those tags. Anytime any tag is changed all tags are written.

Re: Lyricator v1.3.5 (2017-4-8)

by Morbeas » Fri Apr 20, 2018 9:52 pm

Hi there, I'm new to MediaMonkey and Lyricator so please excuse me.

I've recently decided that I'm going to add lyrics as tags to the files (all FLAC) in my library. I have a fairly modest library, about 28,000 tracks so it's certainly not an overnight job but as I was researching how to do this, I came across MM and Lyricator. So I've installed MM and also got Lyricator running and added a test folder with about 5 albums to evaluate.

So my issue is that Lyricator finds the lyrics but then when it writes them to the file (using the LYRICS tag), it also adds other tags as well. For example it adds an additional YEAR tag, as well as ALBUMARTIST, ALBUM ARTIST and ENSEMBLE tags. I've searched the forum and haven't seen this mentioned before so it's kind of weird that I might be the only one with this issue so far, especially considering the plugin is a year old.

Anyway, thanks in advance.

Re: Lyricator v1.3.5 (2017-4-8)

by Mikey1969 » Fri Mar 02, 2018 12:40 pm

Awesome, I'll try this when I get home tonight. Thanks!

Top