Combine Albums 3.2 - Updated 26/12/2012

Post a reply


In an effort to prevent automatic submissions, we require that you complete the following challenge.
Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:

BBCode is ON
[img] is ON
[flash] is OFF
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: Combine Albums 3.2 - Updated 26/12/2012

Re: Combine Albums 3.2 - Updated 26/12/2012

by greggw » Fri Dec 28, 2012 10:48 pm

That fixed my problem! Thanks for the quick fix.

-- Gregg

Re: Combine Albums 3.2 - Updated 26/12/2012

by trixmoto » Wed Dec 26, 2012 10:48 am

New version (3.2) is now available to download from my website. I've fixed disc numbers larger than 9, again.

Re: Combine Albums 3.1 - Updated 16/09/2012

by trixmoto » Wed Dec 26, 2012 8:43 am

I think I've already fixed this issue in the next version, I just haven't got round to releasing it yet. I'll try and get it out later today.

Re: Combine Albums 3.1 - Updated 16/09/2012

by greggw » Sun Dec 23, 2012 9:28 pm

trixmoto - Thanks for writing and sharing great scripts!

I installed Combine Albums 3.1 today and I received an error message every time I try to use the script.
Error #5 - Microsoft VBScript runtime error
Invalid procedure call or argument: 'Left'
File: "C:\Program Files (x86)\MediaMonkey\Scripts\CombineAlbums.vbs", Line: 142, Column: 4
I've been trying to use mode 5 (Disc=1 and Track=1##) of the script. I'm using MediaMonkey version 4.0.7.1511 on a Windows 7 computer. I've tried installing Combine Albums as an Administrator and I've tried using the script as an Administrator, and I get the error regardless.

Any assistance you can provide would be appreciated!

Thanks,

Gregg

Re: Combine Albums 3.1 - Updated 16/09/2012

by trixmoto » Tue Nov 13, 2012 5:34 am

Great, thanks.

Re: Combine Albums 3.1 - Updated 16/09/2012

by andig » Sun Nov 11, 2012 5:52 am

You're right- seems I've mixed up things, 3.1 is working fine ;)
I'll post an update to the regex soon as I'm seeing more naming conventions that could be handled, so stay tuned.

Re: Combine Albums 3.1 - Updated 16/09/2012

by trixmoto » Mon Oct 22, 2012 6:19 am

Can you be more specific about the errors you're getting? I've tried and I'm not getting any errors. And the code you've posted is identical to mine, except you use "CInt" instead of "Int" (which do the same thing, effectively) and you've only got the numeric half of the "if" statements.

Re: Combine Albums 3.1 - Updated 16/09/2012

by trixmoto » Sun Oct 14, 2012 4:50 pm

Ok, I'll take another look.

Re: Combine Albums 3.1 - Updated 16/09/2012

by andig » Sun Oct 14, 2012 4:13 am

Hi Trixmoto,

unfortunately you're updated 3.1 doesn't seem to contain the necessary changes and gives me errors. Only did a quick check but process1..3 need to look like this:

Code: Select all

' 1. AlbumName (CD 1) -> AlbumName and Track=1##

Sub process1(itm, albumname, disc)
'	msgbox("proc1 "&albumname&" "&disc)
  disc = CInt(disc) * 100

  Do While itm.TrackOrder > 100
    itm.TrackOrder = itm.TrackOrder - 100
  Loop

  itm.AlbumName = albumname
  itm.TrackOrder = disc + itm.TrackOrder
End Sub


' 2. AlbumName (CD 1) -> AlbumName and Disc=1

Sub process2(itm, albumname, disc)
'	msgbox("proc2 "&albumname&" "&disc)
  disc = CInt(Left(disc,Len(disc)-2))

  itm.AlbumName = albumname
  itm.DiscNumber = disc
End Sub


' 3. Track=1## -> Disc=1 and Track=##

Sub process3(itm,c)
  Dim s : s = itm.TrackOrderStr
  If Len(s) > 2 Then
    c = c + 1
    itm.DiscNumber = Int(Left(s,Len(s)-2))
    itm.TrackOrder = Int(Mid(s,2))
  End If
End Sub

Re: Combine Albums 3.1 - Updated 16/09/2012

by andig » Sun Sep 16, 2012 4:14 am

Will check asap- thank you!

Re: Combine Albums 3.1 - Updated 16/09/2012

by trixmoto » Sat Sep 15, 2012 9:51 pm

New version (3.1) is now available to download from my website. I have fixed disc numbers larger than 9, thanks to andig.

Re: Combine Albums 3.0 - Updated 11/01/2010

by trixmoto » Sat Sep 15, 2012 8:34 pm

Ok, cheers.

Re: Combine Albums 3.0 - Updated 11/01/2010

by andig » Sat Sep 15, 2012 6:49 am

trixmoto wrote:Ok, I'll see if I can combine the two :) Also, you've changed the regular expressions, but these aren't really my strong suit - do you remember what you changed and why?
Honestly they didn't match my local version and I had no clue where those changes came from (looked like artifacts). Feel free to change them back but please check if the matching brackets where moved and different array indexes of the matches are used further on.

Re: Combine Albums 3.0 - Updated 11/01/2010

by trixmoto » Fri Sep 14, 2012 4:32 am

Ok, I'll see if I can combine the two :) Also, you've changed the regular expressions, but these aren't really my strong suit - do you remember what you changed and why?

Re: Combine Albums 3.0 - Updated 11/01/2010

by andig » Fri Sep 14, 2012 1:11 am

No- I probably didn't recognize this.

Kind regards,
Andreas

Top