Discogs Tagger 5.71 (Updated: 2019-09-23)

Post a reply


In an effort to prevent automatic submissions, we require that you complete the following challenge.
Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:

BBCode is ON
[img] is ON
[flash] is OFF
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: Discogs Tagger 5.71 (Updated: 2019-09-23)

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Fri Feb 28, 2020 7:51 pm

DJSamhein wrote:
Fri Feb 28, 2020 3:25 pm
Doesn't the list provide disc and track # as well? Maybe you could check both.
I can get all information about the selected tracks. This should work. I thought the list is sorted by mm, so i doesn't think about it. :wink:

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Fri Feb 28, 2020 4:44 pm

DJSamhein wrote:
Fri Feb 28, 2020 3:25 pm
crap_inhuman wrote:
Fri Feb 28, 2020 12:36 pm
The Discogs Tagger (DT) get a songlist to search for. The songlist is sorted in alphabetic order of the songname. I thought, the songlist is in "normal" order (by tracknumber and discnumber) This is the problem. DT can't control the order of the songlist, so DT need to sort the songlist internally.
Doesn't the list provide disc and track # as well? Maybe you could check both.
One thing I noticed that doesn't work is, for tracks that aren't detected (left unchecked), if we edit the track # on the list at the bottom, it adds it to the list in the proper order and changes global tags like album or year but not the song name. Maybe it's related?
I don't think so. Normally it should not change the global tags, if you edit something in the list at the bottom. It "should" change it, if you press the Auto-Tag button. This is a bug.
With the list at the bottom the tagger could not interact. MM change the list after the tagger send a new songlist. But the tagger could not control it.

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by DJSamhein » Fri Feb 28, 2020 3:25 pm

crap_inhuman wrote:
Fri Feb 28, 2020 12:36 pm
The Discogs Tagger (DT) get a songlist to search for. The songlist is sorted in alphabetic order of the songname. I thought, the songlist is in "normal" order (by tracknumber and discnumber) This is the problem. DT can't control the order of the songlist, so DT need to sort the songlist internally.
Doesn't the list provide disc and track # as well? Maybe you could check both.
One thing I noticed that doesn't work is, for tracks that aren't detected (left unchecked), if we edit the track # on the list at the bottom, it adds it to the list in the proper order and changes global tags like album or year but not the song name. Maybe it's related?

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Fri Feb 28, 2020 12:36 pm

TLD wrote:
Fri Feb 14, 2020 1:02 pm
DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-Bug: On releases that have the same song name on different discs (e.g., release 5788257), if we select the option to tag disc# and track# all instances of that song name will get the same one. In this example, the song "Blood Of Love" in disc 1 and 2 will both be tagged as disc 2. Same with the other ones that have the same name.
I've been dealing with this since the Amazon links broke.

Usually I make note of which song(s) it did this for, and adjust them accordingly.

Sometimes it's made worse by the fact that the same song appears many times - such as a single with multiple versions (acoustic, "DJ X", etc.) where they all get tagged with the last entry matching the title.

Software can't tell which it should match, so "last in" - I don't see this as something easily fixed unless the software _checks_ the existing track# before fixing it... and if the title already doesn't match, you'll run into the same problem.
"In The Wee, Small Hours Of The Morning" doesn't match "In The Wee Small Hours Of The Morning" as an example...

- TLD
I think i found the cause of the problem:

As long as the song names are unique, the matching works. But....

The Discogs Tagger (DT) get a songlist to search for. The songlist is sorted in alphabetic order of the songname. I thought, the songlist is in "normal" order (by tracknumber and discnumber) This is the problem. DT can't control the order of the songlist, so DT need to sort the songlist internally.

This is the cause of this bug, too:
DJSamhein wrote:
Thu Feb 27, 2020 5:43 am
In this case, if I also uncheck song 9, it will still try to rename song 7 with song 9's name.
Sometimes, instead of trying to change the name to another (random?) song, it will simply remove it from the bottom list (uncheck it).
I rewrite this part of the Tagger.

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by DJSamhein » Thu Feb 27, 2020 10:33 am

In this case, the first result that popped up matched all files without any modification (no yellow) and if I uncheck track 7 it works fine. It's when I switch to the second result that it behaves like this. I don't know if your logs reflect switching results and unchecking the box, but either way here's the log after I duplicated the situation in the image.

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Thu Feb 27, 2020 9:23 am

This is weird, could you please send me the LOG-File ?

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by DJSamhein » Thu Feb 27, 2020 5:43 am

Ok, so I found another small bug, which I don't know if it's caused by the discogs tagger or if it's caused by MM.
Occasionally, when tagging an album, there is a song that isn't correct so I unclick the right most checkbox (the one that supposedly controls the song name).
Most of the time if works fine and the song name won't be changed but it remains in the list and updates all other tags (album art, album name, year, etc).
But sometimes it will screw up and decide to change the name to another song altogether. I have uploaded a screenshot of this situation. In this case, if I also uncheck song 9, it will still try to rename song 7 with song 9's name.
Sometimes, instead of trying to change the name to another (random?) song, it will simply remove it from the bottom list (uncheck it).

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Sat Feb 22, 2020 4:44 pm

Please tell me more about your system. Which Version of Windows, Internet Explorer, Media Monkey and Discogs Tagger do you use ?

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by freisgd » Mon Feb 17, 2020 12:26 pm

crap_inhuman wrote:
Sun Feb 02, 2020 2:11 pm
Please open the following page in your Internet Explorer : https://clienttest.ssllabs.com:8443/ssl ... lient.html

This page test your Browser about supported protocols. Under Protocol Features you should have TLS 1.2 -> yes
I'm having this issue as well.
Protocols
TLS 1.3 Yes
TLS 1.2 Yes
TLS 1.1 Yes
TLS 1.0 Yes
I'm getting the error Line 6525 Column 3

Is there a solution to this issue that I have missed?

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by TLD » Fri Feb 14, 2020 1:02 pm

DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-Bug: On releases that have the same song name on different discs (e.g., release 5788257), if we select the option to tag disc# and track# all instances of that song name will get the same one. In this example, the song "Blood Of Love" in disc 1 and 2 will both be tagged as disc 2. Same with the other ones that have the same name.
I've been dealing with this since the Amazon links broke.

Usually I make note of which song(s) it did this for, and adjust them accordingly.

Sometimes it's made worse by the fact that the same song appears many times - such as a single with multiple versions (acoustic, "DJ X", etc.) where they all get tagged with the last entry matching the title.

Software can't tell which it should match, so "last in" - I don't see this as something easily fixed unless the software _checks_ the existing track# before fixing it... and if the title already doesn't match, you'll run into the same problem.
"In The Wee, Small Hours Of The Morning" doesn't match "In The Wee Small Hours Of The Morning" as an example...

- TLD

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by DJSamhein » Wed Feb 12, 2020 4:33 am

crap_inhuman wrote:
Tue Feb 11, 2020 2:49 pm
DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-Bug: On releases that have the same song name on different discs (e.g., release 5788257), if we select the option to tag disc# and track# all instances of that song name will get the same one. In this example, the song "Blood Of Love" in disc 1 and 2 will both be tagged as disc 2. Same with the other ones that have the same name.
Are you sure that this bug didn't occur in older versions of the Tagger? I know that MM has problems with more than one track with the same song name in a release. You can't control which song will be tagged if you use auto-tag from web.
It's possible it happened in earlier versions. I can't really remember. I know that it happens sometimes. I thought you might have some control over the selection.
One thing that also happens a lot is that a song isn't properly recognized because the name is slightly different. For example, the tracklist has it as "Song Name" and I have "Song Name (Demo)" and it doesn't detect it, even though there might be other songs in the same condition and those get identified. And changing the track number in the bottom list gets them tagged with the "global" tags (album, year, artist, etc) but it doesn't change the name.
If you can't control it, then it's ok, I'll just work around it as I've been doing, it's just a little annoying at times.
crap_inhuman wrote:
Tue Feb 11, 2020 2:49 pm
DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-QoL: Is it possible to add an option to capitalize song names and another for album name? So that something like "This and that" will be shown and tagged as "This And That"?
This option should be easy, too. But the most song and album names on Discogs are already capitalized. I'm thinking about it. :wink:
Yes, most are capitalized but there are always some that aren't. And sometimes it happens on releases where I want to fix a song name and I have to either jump through hoops to get it to tag properly or simply let it tag songs in lower case and then fix them afterwards.
As I said, it's a QoL improvement. I can do without it and have for a long time, it's just more convenient for some situations. No biggie if it's too much effort and you don't do this :)

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Tue Feb 11, 2020 2:49 pm

DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
I have a sort of bug to report and two QoL options to be added, if possible:

-Bug: On releases that have the same song name on different discs (e.g., release 5788257), if we select the option to tag disc# and track# all instances of that song name will get the same one. In this example, the song "Blood Of Love" in disc 1 and 2 will both be tagged as disc 2. Same with the other ones that have the same name.
Are you sure that this bug didn't occur in older versions of the Tagger? I know that MM has problems with more than one track with the same song name in a release. You can't control which song will be tagged if you use auto-tag from web.
DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-QoL: In many releases (possibly due to keyboard constraints of the user inserting the release) instead of a single quote there is an accent character. So that instead of "I'm" it's "I´m". Is it possible to add an option to replace ´ with ' ?
This option should be easy to implement. I will add it in the next release.

DJSamhein wrote:
Thu Feb 06, 2020 7:03 am
-QoL: Is it possible to add an option to capitalize song names and another for album name? So that something like "This and that" will be shown and tagged as "This And That"?
This option should be easy, too. But the most song and album names on Discogs are already capitalized. I'm thinking about it. :wink:

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Tue Feb 11, 2020 2:37 pm

I just tried tagging without the modification from my last post and it works again. Totally weird. :lol:

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by DJSamhein » Fri Feb 07, 2020 5:49 pm

It tagged fine for me.
I occasionally get an error loading a release, but it must be either a network error or something temporary, because switching to another release and going back usually loads it properly.

Re: Discogs Tagger 5.71 (Updated: 2019-09-23)

by crap_inhuman » Fri Feb 07, 2020 2:52 pm

I don't know why, but i want to see the bug DJSamhein reported, started the DiscogsTagger and got an error in line 6525.
I changed the line 6294 from

Set oXMLHTTP = CreateObject("MSXML2.XMLHTTP.6.0")

to

Set oXMLHTTP = CreateObject("MSXML2.ServerXMLHTTP.6.0")

and the same in line 5008. After that, the Tagger works again.

I don't understand it....

Anyone have the same problem ?

Top