I might need to create a debug version to see what this isn't working...

Ok, I do have some with non-alpha characters so I can understand why they are not working but I also have some without. An example, the file name is 112 - Dance With Me Remix.mp3, the EL file name is 112 - Dance with Me Remix. I have El setup to rename the lyrics as the same as the file.

Nyn

I need to know the Artist name and the Track title. I think the problem is probably because EvilLyrics is saving the lyrics in a different file than the script is looking for, probably due to a non-alpha-numeric character.

These are the only variables which I changed for the script:

Dim EvilLyrics : EvilLyrics = "w:\Music\Music Library\lyrics\" '(*) leave blank if you don't want this feature
Dim RecheckSecs : RecheckSecs = 3 'number of seconds before rechecking EvilLyrics

I don't know what details you want for the mp3 file but the lyric files are downloading to the directory above.

Nyn

You'd have to let me know what your variables are at the top of your script, what the track details are, and where the EvilLyrics file is for this track.

That's probably where the problem for some of the files lies since I've been using both Evillyrics and Minilyrics to download files, not sure which is the program which downloaded the file but there are some which EL has just downloaded but it is not being picked up by LT.

Any other thoughts??

Nyn

Well it only picks up lyrics which EvilLyrics have already downloaded and saved. Are you sure EvilLyrics had created a file for the track you are viewing using this script?

Trixmoto:

I am trying to give this script a whirl in order to download lyrics from EvilLyrics but although I have pointed it to the directory where my lyrics are being stored, it is not generating the lyrics in the viewer. Is there a setup somewhere else I should be changing??

Nyn

New version (3.0) is now available from my website. This has many new features including...

- Should now run in "My Computer" security zone
- Fixed error on save because data missing
- Added automatic importing from EvilLyrics (*)
- Added function to add lyric lines
- Added function to edit lyric lines
- Added function to delete lyric lines
- Fixed highlighting from getting out of sync

* Note that the lyrics are not saved in the tags until you hit the save button. You must specify the path to your EvilLyrics in the script, or make it blank if you do not wish to use this feature.

Thanks for finding that bug [b]orthimas[/b]. I am working on a new version at the moment, although as I'm working on new versions of other scripts too, it might be a while before it's ready for release.

I was having the same problem, where I would get an error dialog with general errors over it.

I got it to work flawlessly by making the following adjustments:
1) In internet explorer, changing my "Internet" security settings to enable "Initialize and script ActiveX controls not marked as safe"
2) Added in a reference to Data in Sub SaveClick - updated code:
[code]Sub SaveClick (ClickedBtn)
Dim res,str,pos,lng,song,Data
res = SDB.MessageBox("Are you sure you wish to save your changes?",mtConfirmation,Array(mbOk,mbCancel))
Set Data = SDB.Objects("LyricData")
If res = 1 Then
str = ""
pos = 1

If Data.Item("title") <> "" Then
str = str&"[ti:"&Data.Item("title")&"]"&vbcrlf
End If
If Data.Item("artist") <> "" Then
str = str&"[ar:"&Data.Item("artist")&"]"&vbcrlf
End If
If Data.Item("author") <> "" Then
str = str&"[au:"&Data.Item("author")&"]"&vbcrlf
End If
If Data.Item("album") <> "" Then
str = str&"[al:"&Data.Item("album")&"]"&vbcrlf
End If
If Data.Item("version") <> "" Then
str = str&"[ve:"&Data.Item("version")&"]"&vbcrlf
End If

Do While Data.Item("time"&pos) <> ""
lng = Clng(Data.Item("time"&pos))
If Right(str,2) <> vbcrlf Then str=str&vbcrlf
str = str&settime(lng)
str = str&Data.Item("line"&pos)
pos = pos + 1
Loop

Set song = SDB.Player.CurrentSong
song.Lyrics = str
song.UpdateDB
End If
Set Data = Nothing
End Sub[/code]

Now it works perfectly - except that little COM error. It doesn't freeze my system, but it does make me click "Yes" to allow closing. It seems to be hinged on the use of Internet Explorer. Even if I close it before I close MM, it gives me the error.

Thanks for a great product!
~ Orthimnas ~

Yes, unfortunately because the timer is set to run every 100ms so you get a good update speed, once an error occurs you get too many message to deal with (10 a second!) - can't find a way to catch these properly.

I will look at this line and see if I can work out the problem.

Cheers for your help :)

Update.

I've tried manually adding the script as well as re-running the installer, but I'm still getting the following:

1. A dialogue box which says "Error executing script event"

2. This is covering up a dialogue which is displaying the runtime error. If I ok or attempt to move 1. - it copies itself.

I can make out this much of the runtime error:

Error #424.......................................................Line 131 Column 4

(which I think is an object required problem). The line is:

[code] classname = doc.getElementById("row"&newcurr).className[/code]

NB The player continues to play, but because the errors are stealing focus, I have to ctrl-alt-del the app.

OK. No offence intended.

I'll have another go with it, and see what I can find. I'll get back to you. Thanks.

Well I don't get the errors so unless you can give me a hint, I've nothing to fix.

The Inno Setup Installer program I use to create the installers for my scripts does change the name of the MediaMonkey uninstall, but that's all. You'll find this will all the installers.