Trailing line break in comments [#14599]

To get bugs in the current release fixed, please report them here.

Moderator: Gurus

Scott
Posts: 55
Joined: Sat Feb 07, 2004 1:37 pm

Trailing line break in comments [#14599]

Post by Scott » Fri Jun 08, 2018 1:31 pm

Sorry if this is covered elsewhere, I did search the forum as best I could first.

At some point in the last few releases, MMW's behavior started changing in the Comments field. Suddenly, any trailing line breaks have vanished. Or if they've vanished, the edit box has started ignoring them. To reproduce: edit a track, enter text in the comments field, hit return after the last bit of text. Verify you can position your cursor at the start of the first empty line. Save, edit the track again, and try to position your cursor at the start of the first empty line - you can't.

I don't know if that last CR/LF is getting trimmed as whitespace on save, or if the edit box is simply ignoring it. I don't really think it's a trim in action, because the behavior is universal - they behave as gone from tracks I haven't edited in years.

This isn't the end of the world, obviously, but it is annoying - if I want to add text to the comment, I can't simply click anywhere on the area past the text and get positioned on the next line ready to go. I have to click very carefully on the exact end of the last line, then hit End to get there when I inevitably miss. Done over and over again and it's enough trouble for me to get frustrated.

More importantly, it's effectively changing my data against my will. I put those trailing carriage returns on 80,000+ tracks for a reason, and they shouldn't be removed/suppressed against my will. Give me back my CR/LFs! ;)

I didn't see anything about this in the release notes, though I could have missed it, so I think it's a bug. If it's not a bug and rather an intentional "feature," is there an option to disable it?

Peke
Posts: 11129
Joined: Tue Jun 10, 2003 7:21 pm
Location: Serbia
Contact:

Re: Trailing line break in comments

Post by Peke » Fri Jun 08, 2018 7:27 pm

Not sure I follow, but I see CRLF in My comments.

Can you please put it in exact steps and if possible record small video, along with file samples containing tags before edit and after edit (Send me DL Links in PM)?
Best regards,
Pavle
MediaMonkey lead QA/Tech Support guru
Admin of Free MediaMonkey addon Site HappyMonkeying
Image
Image
How to add Images to forum

Scott
Posts: 55
Joined: Sat Feb 07, 2004 1:37 pm

Re: Trailing line break in comments

Post by Scott » Sat Jun 09, 2018 11:26 am

I didn't say there are no CRLFs in comments, I said there are no trailing CRLFs in comments. That is, you can't have a blank line(s) after all the text.

To reproduce:
1) edit a track
2) enter text in the comments field
3) hit return after the last bit of text.
4) verify you can position your cursor at the start of the last empty line (after all the text).
5) save
6) edit the track again
7) try to position your cursor at the start of the first empty line (after all the text).

If you now have a cursor sitting at an empty line after all the text, it didn't reproduce.
If there is no empty line after all the text, there should have been - you reproduced it.

Edit: I forgot to say, I don't know how to create a video. Let me know if the steps above aren't clear enough and I can look into it.

Lowlander
Posts: 44540
Joined: Sat Sep 06, 2003 5:53 pm
Location: MediaMonkey 5

Re: Trailing line break in comments

Post by Lowlander » Mon Jun 11, 2018 11:54 am

Yes, both trailing Carriage Returns and Spaces are trimmed from the Comments field (probably others too). This was done with: https://www.ventismedia.com/mantis/view.php?id=14599
Lowlander (MediaMonkey user since 2003)

Scott
Posts: 55
Joined: Sat Feb 07, 2004 1:37 pm

Re: Trailing line break in comments

Post by Scott » Mon Jun 11, 2018 2:43 pm

Aha! Yes, that's it. Thanks Lowlander.

It looks like a trim was added, mainly to prevent problems with filenames. It's not clear why the fix was extended to metadata, though it makes sense for fields that aren't as freeform as Comments. Do you know if the INI option was implemented, and if so what the option is?

Lowlander
Posts: 44540
Joined: Sat Sep 06, 2003 5:53 pm
Location: MediaMonkey 5

Re: Trailing line break in comments

Post by Lowlander » Mon Jun 11, 2018 3:03 pm

ini switch isn't further discussed, so I assume not.
Lowlander (MediaMonkey user since 2003)

Peke
Posts: 11129
Joined: Tue Jun 10, 2003 7:21 pm
Location: Serbia
Contact:

Re: Trailing line break in comments

Post by Peke » Mon Jun 11, 2018 8:27 pm

Hi,
Just of curiosity why you need empty line in the end of comment?
Best regards,
Pavle
MediaMonkey lead QA/Tech Support guru
Admin of Free MediaMonkey addon Site HappyMonkeying
Image
Image
How to add Images to forum

Ludek
Posts: 2430
Joined: Fri Mar 09, 2007 9:00 am

Re: Trailing line break in comments

Post by Ludek » Tue Jun 12, 2018 6:01 am

Hi, OK, based on the feedback re title and comment it makes sense to not trim CR+LF and spaces for these fields. And trim them only for album, artist and genre for the reasons described by me at https://www.ventismedia.com/mantis/view ... 599#c49581 .

This will be fixed in 4.1.21.1870 and 5.0.0.2112

Scott
Posts: 55
Joined: Sat Feb 07, 2004 1:37 pm

Re: Trailing line break in comments

Post by Scott » Tue Jun 12, 2018 8:58 am

Excellent, thank you Ludek!

Peke, see OP.

Scott
Posts: 55
Joined: Sat Feb 07, 2004 1:37 pm

Re: Trailing line break in comments

Post by Scott » Sun Jun 17, 2018 2:09 pm

Confirmed in 4.1.21.1870, thanks again!

Post Reply