Lyrics and Comment Viewer 2.2 (2011-04-24) [MM3+4]

[dypsis]

@dypsis
Ionized MR are on the way!

Awesome mate.

[dypsis]

Something that I would like to see is the ability to adjust line spacing.
It appears that line spacing is set to about 1.5.

I would rather a 1 line spacing. What do you think?

[gege]

Something that I would like to see is the ability to adjust line spacing.
It appears that line spacing is set to about 1.5.
I would rather a 1 line spacing. What do you think?

You can easily edit style.css and adjust line-height for p element, like this:

Code: Select all

p  { ...
line-height: 120%;
... }

You can test various percentages 'til you find a spacing that you like.
Original spacing seems to be near 150%.

[nynaevelan]

If we are putting requests out there, I would like to see an option like in Monkey Rok where you can click on the header and switch between modes. This would be handy when editing files to look for lyrics. (just a hint, not a requirement. )

Nyn

[gege]

If we are putting requests out there, I would like to see an option like in Monkey Rok where you can click on the header and switch between modes. This would be handy when editing files to look for lyrics. (just a hint, not a requirement. )

Probably beyond my skills

And doesn't Mixed Mode fit this need?

[nynaevelan]

Ok, I can live with that. Mixed mode only lets you select a track when a track is not playing and it is VERY rare that I do not have a track playing.

Nyn

[gege]

Ok, I can live with that. Mixed mode only lets you select a track when a track is not playing and it is VERY rare that I do not have a track playing.

Then we have "Selected Song mode"

[nynaevelan]

Ok, I can live with that. Mixed mode only lets you select a track when a track is not playing and it is VERY rare that I do not have a track playing.

Then we have "Selected Song mode"

U r totally missing the point. My point was I wanted a quicker way to switch between modes without having to go to the Options panel each time. Since I have several thousand tracks without lyrics, I work on them in small batches. Which means I want to be in selected mode but any other time I want to be in mixed mode. So to be able to do it from the panel itself is more convenient than the Options Panel.

Nyn

[gege]

U r totally missing the point.

I'm not! In this last post I was just kidding, in fact
I know you want to save some clicks! I just don't know how much I should have to change in LV to support this. My VB skills are not very good, so I need to keep code simple. I suspect this right-click thing should involve java-script code... I will take a look at MR, just to see how it's done.
For the moment, I just anticipate this is unlikely to happen...

[nynaevelan]

Ok, I can live with that...

Nyn

[ZvezdanD]

I suspect this right-click thing should involve java-script code...

Maybe you could take a look at source code of the Event Logger 2.1 which has a context menu I did in VBScript (version 2.0 had it with JavaScript). Let me know if you need some help.

[RifRaf]

Any idea why a multiline comment tag would not display correctly in the viewer? have attached example that shows how the comment displays if i view them in file properties and the viewer


have had the same issue with lyrics that were added to the file by a different program. in that case the lyrics still displayed correctly in the file properties but have used lyricator to correct the lyrics now. the comments tag is generated from advanced relationships from musicbrainz, since many of these tags are not supported by mediamonkey i find its a usefull comment to display in this viewer.

edit: the issue seems to stem from the newline character/s . To get the Viewer to display correctly text must use 0x0d 0x0a as a line ending (/r/n) . Can the Viewer be modified to treat just a newline character as line ending? ie. 0x0a or /n . This would likely apply to all files that are tagged on a unix/linux based system or in my case a windows application that uses unix style line endings. will have a look at the code and try.

[gege]

edit: the issue seems to stem from the newline character/s . To get the Viewer to display correctly text must use 0x0d 0x0a as a line ending (/r/n) . Can the Viewer be modified to treat just a newline character as line ending? ie. 0x0a or /n . This would likely apply to all files that are tagged on a unix/linux based system or in my case a windows application that uses unix style line endings. will have a look at the code and try.

Yes. You're right. Your lyrics and comments were saved using line breaks in unix format.
For them to be correctly displayed, open LyricsViewer.vbs file, find line 400, and replace this code:

Code: Select all

    HtmlMarkup=Replace(Txt,vbNewLine,"<br>" & vbNewLine & "                ")

by this:

Code: Select all

    Txt=Replace(Txt,vbLf,vbNewLine)
    HtmlMarkup=Replace(Txt,vbNewLine,"<br>" & vbNewLine & "                ")

[RifRaf]

thanks gege, that did the trick perfectly

[Benn]

Hey Gege, just coming in from the Agora thread: thanks for your suggestions about editing the .css. I am slightly confused however: whatever I do to change the css file found in LyricsViewer\Themes\Agora, nothing seems to change at all. I even deleted everything inside the css to check.

I close MM, wait for it to back itself up, then save my changes and open MM again, but to no avail. Am I doing anything wrong?

Thanks.