THIS IS EXCITING NEWS!!!eepman wrote:I was gettin' bummed without having discogs tagging working right, and I put some work in to it a while back, so I went ahead and did that JSON bizness let was talking about.
I found some crazy japanese vbscript JSON parser here: http://demon.tw/my-work/vbs-json.html#code
Many many thanks to that dude, although his code wasn't quite right, so a few hours of fixing the parser and bam I got us back a working DISCOGS TAGGER!! USING THE NEW DISCOGS JSON API!! (Okay so some of the fancier features aren't implemented and teh release details are still accessed the old xml way but at the least the search works again!!)
This is a VERY EARLY ALPHA version of the revised script and yeah it has some not nice error messages when a search doesn't return results and junk like that.
But go for it I guess, I'm not responsible if your computer blows up though!
https://docs.google.com/file/d/0B9BeBOq ... dpN2c/edit
EDIT: So I put up an updated version where the result information itself is retrieved with the new JSON API as well, it's a bit faster than the old version and easier to see which release you are picking in the search results, but there are a number of bugs i'm still working out with artist name formatting and junks like that. Go ahead and report bugs in this thread if you want to. thx. The link is the same: https://docs.google.com/file/d/0B9BeBOq ... dpN2c/edit
ps. There's definitely room for some cool new advanced features like multiple images per release and stuff that I may take a look at in the near future. ;D
Discogs Tagger 3.62 (Updated: 2013-02-09)
-
- Posts: 18
- Joined: Sat Jan 09, 2010 7:51 am
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
-
- Posts: 18
- Joined: Sat Jan 09, 2010 7:51 am
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Why doesn't this extension have an *.mmip ending? How am I supposed to run it?
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
I'd guess you replace the existing vbs with the new one.
Download MediaMonkey | License
Help: Knowledge Base | MediaMonkey for Windows 5 | MediaMonkey for Android
Lowlander (MediaMonkey user since 2003)
Help: Knowledge Base | MediaMonkey for Windows 5 | MediaMonkey for Android
Lowlander (MediaMonkey user since 2003)
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Pushed another update with a few bugfixes to my new JSON version: https://docs.google.com/file/d/0B9BeBOq ... dpN2c/edit
Let me know if you find any bugs, thx.
Oh and you just replace your existing DiscogsAutoTagWeb.vbs in your mediamonkey scripts folder to install for now, I'll put together an mmip soon for easier installation. The vbs is either in the install directory or in your AppData in your user directory.
Let me know if you find any bugs, thx.
Oh and you just replace your existing DiscogsAutoTagWeb.vbs in your mediamonkey scripts folder to install for now, I'll put together an mmip soon for easier installation. The vbs is either in the install directory or in your AppData in your user directory.
radium.io -- build software fearlessly
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
First of all, thanks eepman for your vb script.
Well, I had an error with your script (line 196, incompatible type : cdbl). I'm french and the problem is that French language machines use ',' as a decimal point, not the '.'
So I replace your original code
with
It now works like a charm! But if you can do something about that, to prevent people from manipulating the code, it would be great!
Cheers.
Well, I had an error with your script (line 196, incompatible type : cdbl). I'm french and the problem is that French language machines use ',' as a decimal point, not the '.'
So I replace your original code
Code: Select all
ParseValue = CDbl(ms(0))
Code: Select all
ms2=Replace(ms(0), ".", ",")
ParseValue = CDbl(ms2)
Cheers.
-
- Posts: 18
- Joined: Sat Jan 09, 2010 7:51 am
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Works superb! So far...
Another question: if anyone has a what.cd invite to spare, please send me a PM
Another question: if anyone has a what.cd invite to spare, please send me a PM
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Thank you so much eepman for getting the Discogs Tagger back to life! Tried it on a few tracks. As far as I can see now it works like a charm!
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
eepman,
Thank you for picking up this script!
I have run into a small issue. I am not sure if this is one of those things that you needed to address at a later date. The script does not save the Date in the month/day/year format (or year-month-day for that matter). It is acting like the "Use Years Of Dates" option is enabled even though it is not checked. I just wanted to make you aware of this, in case you have not spotted it.
Thank you for picking up this script!
I have run into a small issue. I am not sure if this is one of those things that you needed to address at a later date. The script does not save the Date in the month/day/year format (or year-month-day for that matter). It is acting like the "Use Years Of Dates" option is enabled even though it is not checked. I just wanted to make you aware of this, in case you have not spotted it.
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
eepman,
I need to make a correction to my last post. I did some further testing today and it is now working. It correctly inserted the date in the month/day/year format. I tried to go back and find the album that I was having the problem with, but was unable to locate it. Now, I do not know if I overlooked something, if it was just that particular release or something else. Regardless, it appears to be working on these other albums. So, it probably was just something on my end.
I need to make a correction to my last post. I did some further testing today and it is now working. It correctly inserted the date in the month/day/year format. I tried to go back and find the album that I was having the problem with, but was unable to locate it. Now, I do not know if I overlooked something, if it was just that particular release or something else. Regardless, it appears to be working on these other albums. So, it probably was just something on my end.
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
A long time we can't use this superb script and now we have 2 Versions..
I worked also on an JSON Parser for this Discogs Script. I removed some bugs and added some interesting (in my opinion) features.
Changes from 3.3 to 3.5 by crap_inhuman in 01.2013
Now you can choose which Custom Tag will be used for the Tags: ReleaseID, Catalog, Country and Format
The "Credits for ExtraArtists in tracks" will now saved in MediaMonkey !
Added option for "Add Leading zero to Tracknumbers"
Added option for "Include Producer"
Added JSON Parser for the new Discogs-API
Some bugfixes (Filter now working correct)
Added the option to choose the place for Featuring Artist (Artist or Title)
e.g. Aaliyah - We Need a Resolution (ft. Timbaland) -or- Aaliyah (ft. Timbaland) - We Need a Resolution
Changeable Name for "Various" Artists (Various Artists)
Added option for "Adding comment"
Get OriginalDate from Master-Release if available
The Script now reads the saved Discogs Release-ID from the choosen Release-Tag
Get "another" new Version of the Discogs Script here : http://www.germanc64.de/DiscogsAutoTagWeb.vbs
Please report bugs and/or wanted features in this forum.
In the meanwhile eepman and my person throwing our 2 scripts together and "cooking" a new version. @eepman: How do you think about this?
I worked also on an JSON Parser for this Discogs Script. I removed some bugs and added some interesting (in my opinion) features.
Changes from 3.3 to 3.5 by crap_inhuman in 01.2013
Now you can choose which Custom Tag will be used for the Tags: ReleaseID, Catalog, Country and Format
The "Credits for ExtraArtists in tracks" will now saved in MediaMonkey !
Added option for "Add Leading zero to Tracknumbers"
Added option for "Include Producer"
Added JSON Parser for the new Discogs-API
Some bugfixes (Filter now working correct)
Added the option to choose the place for Featuring Artist (Artist or Title)
e.g. Aaliyah - We Need a Resolution (ft. Timbaland) -or- Aaliyah (ft. Timbaland) - We Need a Resolution
Changeable Name for "Various" Artists (Various Artists)
Added option for "Adding comment"
Get OriginalDate from Master-Release if available
The Script now reads the saved Discogs Release-ID from the choosen Release-Tag
Get "another" new Version of the Discogs Script here : http://www.germanc64.de/DiscogsAutoTagWeb.vbs
Please report bugs and/or wanted features in this forum.
In the meanwhile eepman and my person throwing our 2 scripts together and "cooking" a new version. @eepman: How do you think about this?
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
MMW Gold Lifetime v4.1.21.11875
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge
Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/
"Being mean to someone takes more effort than being nice to them"
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge
Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/
"Being mean to someone takes more effort than being nice to them"
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Thanks for your reply. I found the bug and uploaded the corrected version
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Works great. Thank you very much!
MMW Gold Lifetime v4.1.21.11875
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge
Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/
"Being mean to someone takes more effort than being nice to them"
MM Pro Android v1.3.2.0824
Windows Home 10.0.17134.228 64-bit Build 1803
MS Edge
Next to MediaMonkey, the best program available: Total Commander http://www.ghisler.com/
"Being mean to someone takes more effort than being nice to them"
-
- Posts: 933
- Joined: Sat Jan 26, 2013 6:00 am
- Location: Friedberg / Hessen / Germany
- Contact:
Re: Discogs Tagger 3.5 (Updated: 2013-01-26)
I am very pleased to hear that.
I prepared a mmip-File for an uncomplicated Update of the Script : http://www.germanc64.de/mm/DiscogsAutoTagWeb.mmip
I prepared a mmip-File for an uncomplicated Update of the Script : http://www.germanc64.de/mm/DiscogsAutoTagWeb.mmip
Metal up your ass !
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.
Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0
-----------------------------------------------
I added my first 2 videos on youtube. The language is german.
Discogs Autorisierung: https://www.youtube.com/watch?v=oryxKKtnEnc
Discogs Tagger Bedienung: https://www.youtube.com/watch?v=85Wk-5rd-W0
Re: Discogs Tagger 3.3 (Updated: 2011-11-10)
Thanks crap_inhuman for this new version with some interesting features.
I noticed a problem though. When I want to tag a track which is a featuring, I've got the "feat" in the artist field duplicated (e.g: xxxx Feat. yyyyy -> xxxx Feat. yyyy ft. yyyy). I guess this is related to your new feature "feat. Artist behind title" because when I check this box, it works as expected in most cases.
Also noticed that this problem only happens when the Featuring credits are mentionned for the track on Discogs.
I noticed a problem though. When I want to tag a track which is a featuring, I've got the "feat" in the artist field duplicated (e.g: xxxx Feat. yyyyy -> xxxx Feat. yyyy ft. yyyy). I guess this is related to your new feature "feat. Artist behind title" because when I check this box, it works as expected in most cases.
Also noticed that this problem only happens when the Featuring credits are mentionned for the track on Discogs.