Page 1 of 2

1209 Quick search for C:\ matches T.B.C. [BUG#5186]

Posted: Sun Jan 11, 2009 9:57 pm
by chrisjj
A quick search for C:\ falsely matches tracks having the title T.B.C..

Likewise for S:\ falsely matches tracks having the title S.O.S..

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:29 pm
by Lowlander
That's not unexpected as certain characters are ignored.

The problem seems though that "C:\" doesn't work.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:32 pm
by chrisjj
> That's not unexpected as certain characters are ignored.

Which characters??

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:34 pm
by Lowlander
That I don't know, but I assume the documentation will updated on this at some point.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:36 pm
by chrisjj
If you don't know what characters are being ignored, what's your basis for claiming this behaviour is "not unexpected"?

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:41 pm
by nohitter151
chrisjj wrote:If you don't know what characters are being ignored, what's your basis for claiming this behaviour is "not unexpected"?
From another thread:
rusty wrote:I think, that the current behavior makes sense:
a) Search for 'special character' --> special character is found
b) Search for 'special character' appended to other text --> special character is ignored
c) Search for 'special character' appended to other text all in quotation marks --> special character isn't ignored (an exact match must be found)

Regarding b), I tried out a couple of search engines, and it seems that special characters are generally ignored when doing full-text searches. However, as to whether this makes the most sense for MediaMonkey users, I'm not sure. Like ChrisJJ pointed out, there was only one complaint about it at http://www.mediamonkey.com/forum/viewto ... =6&t=34710 . On the other hand, the current implementation gives more flexibility since users can search for "B.B. King" or Trad. and get results. At the same time, I'm sure that many users won't even think to use Quotes and will wonder why a search for :30 isn't returning the expected results.

-Rusty

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:42 pm
by Lowlander
And found this:
I think the following above indicates which characters are omitted:
Nevertheless per discussion with Jiri over IM we could switch to the old search (we had in MM 3.0) in the case when only a single special char is typed to search bar('/','\','?',',','|',':','.','_','(',')','[',']','&','@','#','+','*','!','-',';')

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Sun Jan 11, 2009 10:47 pm
by Lowlander
Looking at the results it seems to find anything that has the drive letter and a space or special character.

So:
S.
S:
S kk
S\
match

and:
Snow
Super
don't match

Seems to be a good implementation for me. What's off is that "S:\" should find all tracks on the S drive if path is a searchable column.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Mon Jan 12, 2009 7:33 am
by chrisjj
> Looking at the results it seems to find anything that has the drive letter and a space or special character.

Yup - a real PITA.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 10:48 am
by Lowlander
It's actually not a bug as "" only returns full matches not partial matches. The bug might be that it doesn't adhere to this completely and still returns certain partial matches.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 11:03 am
by chrisjj
> It's actually not a bug as "" only returns full matches not partial matches.

Firstly, that's a contradiction of your previous: "S:\" should find all tracks on the S drive if path is a searchable column.
Secondly, it's untrue. e.g. "15 Grandes" matches 15 Grandes Éxitos [08427328020473].
Thirdly, it's irrelevent - the failed query I am reporting does not include quotes.

Unless you have grounds for rejecting this bug report, please file it in Mantis. Thanks.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 11:12 am
by Lowlander
Yes I contradicted myself, as I was incorrect as Ludek explained in Mantis.

"S:\" returns no results which is correct as "" search full field not partial
S:\ returns everything with S followed by special character. The only missing is matches on drive name which I don't if it is a bug or not.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 1:29 pm
by chrisjj
> Yes I contradicted myself, as I was incorrect as Ludek explained in Mantis.

OK, fine.

> S:\ returns everything with S followed by special character.

And how is that not a bug? E.g. wheres the definition that says that is correct behaviour? Certaintly I dont see such in the tooltip.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 1:54 pm
by Lowlander
Well we already know that special characters are ignored as that has been discussed before. This means that C:\ matching T.B.C. is not an illogical result. One would also expect that all files on the C drive would match, but this isn't the case.

I hope a developer can comment on this to see if there is a bug or not.

Re: 1209 Quick search for C:\ matches T.B.C.

Posted: Tue Jan 13, 2009 2:06 pm
by chrisjj
> Well we already know that special characters are ignored

Sorry, but you are wrong again. If that were true, C:\ would match every track that C does. It does not. Just try it.