Page 1 of 3

Weird Lyrics Bug(s) [BUG# 5377]

Posted: Wed Jul 15, 2009 2:26 pm
by Risser
Okay, I've found a VERY weird bug.
So, somehow, occasionally, randomly, lyrics on my songs were getting partially reset, to an arbitrary (but short) number of characters, followed by three periods (ellipses).

It was driving me crazy, as I thought it might be one of my many scripts. However, I stopped using them all together and the problem still happened. Randomly, occasionally.

However, I have discovered a means to recreate it! Finally! (version 3.1.0.1256)
First, close MM then reopen it.
Second, find some files you haven't edited yet this session. If you did #1, that should be any files. Make sure the files have substantial lyrics. At least twenty or thirty lines each should suffice.
Third, add the "lyrics" column to your view. (I'm using the standard details view.)
Fourth, stretch the lyrics column wide. You should see that at some point, the lyrics stop filling the column and are permanently abbreviated by ellipses. No matter how wide you stretch the column, they never go away. I think this is minor bug #1.
Fifth, select multiple files and open properties. Notice (if you can see around the dialog & the lyrics column is still showing and open wide), all of the lyrics except the first song selected expand to fill the column.
Sixth, make some change to all the files. You know, set a field so that it will be the same for every file. Then hit OK.
Seventh, view the lyrics of the first file in the list. You should see that the full lyrics have been replaced somehow by the truncated lyrics. But only for this first file. It works for all the rest.

By the way, before they are truncated, you can "unabbreviate" the lyrics for a file by viewing the file properties and pressing OK. If you do this, you can see the lyrics 'expand' in the column. I've used a binary compare tool to compare identical files, where the only difference is that I've 'expanded' one set of lyrics. They are identical, so this is happening in the DB or locally in the UI somehow.

Although, it happens even if the Lyrics column isn't displayed.

Anyway, that's my saga.
Let me know if you have any questions.
Thanks,
Peter

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 15, 2009 4:06 pm
by nynaevelan
Isn't this the same problem as reported here??

Nyn

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 15, 2009 7:49 pm
by Risser
Yeah, that's true.
But, to be fair, I think I've pinpointed exactly what is happening, and have made it recreatable. It doesn't really have anything to do with the album art. Really, it happens whenever you update multiple items.

Peter

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 15, 2009 8:07 pm
by nynaevelan
I agree and I am almost positve Mizery_Made stated the same although he was using album art as an example. And yes he case was reproducable also. Hopefully with the two scenarios the devs will re-open the case to find a resolution.

Nyn

Re: Weird Lyrics Bug(s)

Posted: Sun Jul 26, 2009 2:52 am
by RifRaf
omg the bug has hit me too :(

time to redo all lyrics by the looks of it

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 29, 2009 9:26 am
by Risser
I created a Magic Nodes node to let me know if any show up. I check it once or twice a week, and there are always some on there, even though I try and be careful.

It's pretty pervasive. And annoying.

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 29, 2009 5:27 pm
by Peke
Why I can't replicate this using Clean/New Library? :(

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 29, 2009 7:23 pm
by dypsis
I have been reporting about this bug here for some time now. But I am guessing due to the lack of other people reporting it, there wasn't a lot of effort put into finding the problem.

For me, it happens to the last track to be tagged in an album whenever I add album art.

This means (for example). If I have the album sorted by track number, then the last track to be tagged is Track 1. And consequently, Track 1 lyrics get truncated.

Re: Weird Lyrics Bug(s)

Posted: Wed Jul 29, 2009 9:35 pm
by Peke
OK People, I really want to get bottom of this, but I can't replicate :(

Here is what I used to test Lyrics in originating bug when I found that there is an issue:

Code: Select all

Sub OnStartup
  Script.RegisterEvent SDB, "OnPlay", "Update2"
End Sub 

Sub Update2
 
  Dim lyrics
  lyrics = SDB.Player.CurrentSong.lyrics

  Call SDB.MessageBox( "Load 1 may Show Truncated lyrics ending with '...':" & Chr(10) & Chr(10) & lyrics, 2, Array(4))

  lyrics = SDB.Player.CurrentSong.lyrics

  Call SDB.MessageBox( "Load 2 Show Complete Lyrics:"  & Chr(10) & Chr(10) & lyrics, 2, Array(4))
End Sub
Debugging using this would help. I'm open to suggestions, have we missed something?

Re: Weird Lyrics Bug(s)

Posted: Thu Jul 30, 2009 8:36 am
by Risser
The main thing is, you need to be editing *multiple* items at once. And the lyrics need to be long enough to be truncated.

I don't know what the code above does, but it looks like you're expecting them to truncate as you're playing them or something?

I dunno. When I walk through the steps I entered above on my computer, I can see the lyrics actually extending to fill the column for all of the items except the first one. And then the lyrics are updated exactly as displayed.

It's pretty obvious.

Peter

Re: Weird Lyrics Bug(s)

Posted: Thu Jul 30, 2009 10:20 am
by nynaevelan
Risser wrote:The main thing is, you need to be editing *multiple* items at once. And the lyrics need to be long enough to be truncated.
This is the same that is happening to me, it doesn't matter what kind of editing I am doing, it just matters that there are several tracks selected at once.

Nyn

Re: Weird Lyrics Bug(s)

Posted: Fri Jul 31, 2009 3:43 am
by dypsis
Risser wrote:The main thing is, you need to be editing *multiple* items at once. And the lyrics need to be long enough to be truncated.
Yes. And I think I can add to that.
I think the last track to be tagged is the one that has the lyrics truncated. So that is normally the track at the top of the list. It can differ, depending on how you have the tracks sorted.

Re: Weird Lyrics Bug(s)

Posted: Fri Jul 31, 2009 7:04 am
by nohitter151

Re: Weird Lyrics Bug(s)

Posted: Fri Jul 31, 2009 9:07 am
by Risser
dypsis wrote: I think the last track to be tagged is the one that has the lyrics truncated. So that is normally the track at the top of the list. It can differ, depending on how you have the tracks sorted.
It's weirder than that.
Again, with 3.1 you can show the lyrics column. If you do that, and stretch it VERY wide, you can see, if you haven't viewed properties of any of the tunes, that all of them look "truncated". I'm not sure why, but they ALL end with ellipses at that point.

Then, if you select them all and "show properties", you can see that ALL of the lyrics suddenly 'fill out' and lose their ellipses. All except one, that is. For me, it's always the top one of the list.

Then, if you make any changes that get applied, or even DON'T make changes, but hit OK instead of Cancel, the one song that didn't 'fill out' gets its lyrics abridged.

Really, the problem is that, when these things are multiple-selected, that one doesn't get it's lyrics updated with whatever is updating the lyrics, BEFORE any changes are even made. Then, when the changes are made, that un-updated, truncated lyric is written back to the database or something.

Re: Weird Lyrics Bug(s) [BUG# 5377]

Posted: Fri Jul 31, 2009 6:52 pm
by Peke
As noted in bug http://www.ventismedia.com/mantis/view.php?id=5377 it should be fixed in next build.