Lyricsplugin Search Script

fenrir · Post by **fenrir** » Wed Feb 13, 2008 12:55 pm

first post here =)

Love yr script. It is really amazing how fast the lyrics are searched.

But facing the same problem too. Also, any plan for a batch tagging. I mean no user intervention

Anyway kudos for the script. Really hope the error mentioned above is fixed soon

spacefish · Post by **spacefish** » Thu Feb 14, 2008 4:22 am

Okay, this is pretty much happening at least once (and more!) on every album. It makes this method pretty much useless.

Does anyone have any idea what needs to be fixed? I'd be happy to edit the script myself if someone just tells me what to paste where.

drjboulder · Post by **drjboulder** » Thu Feb 14, 2008 4:31 am

spacefish wrote:Okay, this is pretty much happening at least once (and more!) on every album. It makes this method pretty much useless.

Does anyone have any idea what needs to be fixed? I'd be happy to edit the script myself if someone just tells me what to paste where.

I am scripting illiterate, but it must be some kind of time out issue.
BTW, when I get the error I switch to the next song and then switch back and it tags without problem.

But, yeah that is a PITA also.

fenrir · Post by **fenrir** » Thu Feb 14, 2008 4:43 am

Guess I spoke too soon.

It not working for any songs any more.. Tried restarting MM n everything.. Shows the lyrics but does not save it.. I'd see if i can do somethin abt the problem myself

spacefish · Post by **spacefish** » Thu Feb 14, 2008 7:28 am

drjboulder wrote:
spacefish wrote:Okay, this is pretty much happening at least once (and more!) on every album. It makes this method pretty much useless.

Does anyone have any idea what needs to be fixed? I'd be happy to edit the script myself if someone just tells me what to paste where.
I am scripting illiterate, but it must be some kind of time out issue.
BTW, when I get the error I switch to the next song and then switch back and it tags without problem.

That doesn't work for me otherwise I'd just deal with it. I can "get lucky" and have it tag after closing the auto-tag window, but usually I need to restart MM for it to start working again. Until it doesn't.

MyCsPiTTa · Post by **MyCsPiTTa** » Thu Feb 14, 2008 3:55 pm

I'm a little confused. Does this do the same as Miilyrics (i.e. search and scroll lyrics) but with the advantage that it can add lyrics to your whole library, not just the playing song? That'd be cool.

nohitter151 · Post by **nohitter151** » Thu Feb 14, 2008 4:09 pm

MyCsPiTTa wrote:I'm a little confused. Does this do the same as Miilyrics (i.e. search and scroll lyrics) but with the advantage that it can add lyrics to your whole library, not just the playing song? That'd be cool.

No, it gets plain (static) lyrics, and I believe only for 1 track at a time (correct me if I'm wrong), using a similar interface as "Auto Tag from Web".

drjboulder · Post by **drjboulder** » Thu Feb 14, 2008 10:42 pm

nohitter151 wrote:
MyCsPiTTa wrote:I'm a little confused. Does this do the same as Miilyrics (i.e. search and scroll lyrics) but with the advantage that it can add lyrics to your whole library, not just the playing song? That'd be cool.
No, it gets plain (static) lyrics, and I believe only for 1 track at a time (correct me if I'm wrong), using a similar interface as "Auto Tag from Web".

Exactly, except the interface is not similar - it is one and the same.

Juanitoc · Post by **Juanitoc** » Fri Feb 22, 2008 7:28 pm

irshjet35 wrote:nice script although I get an error when trying to get the lyrics, I get an VBS Runtime error #424 object required 'lyrics' line 74 column 25. I can click past it and it works, just annoying

I finally found how to fix this problem!!!

replace the corresponding piece of code with this:

...............
url = "http://www.lyricsplugin.com/winamp03/plugin/?title=" & title & "&artist=" & artist
Browser.Interf.Navigate url

Set Tmr = SDB.CreateTimer(40)
Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
End If

dim Doc
End Sub

Sub WebsiteLoaded(Timer)
Script.UnregisterEvents Tmr
Set Tmr = Nothing

If Len(Browser.Interf.LocationURL) < 10 Then ' A trick - wait until navigation to the search results page starts
Set Tmr = SDB.CreateTimer(40)
Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
Exit Sub
End If

If Browser.Interf.ReadyState = 1 Or Browser.Interf.Busy Then
Set Tmr = SDB.CreateTimer(40)
Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
Exit Sub
End If

Set Doc = Browser.Interf.Document
If IsObject(Doc) Then
Set lyrics = Doc.getElementById("lyrics")
...............

Guest · Post by **Guest** » Sat Feb 23, 2008 8:11 am

Hey, can you please explain the steps in a little more detail ?

justin_f · Post by **justin_f** » Sat Feb 23, 2008 5:05 pm

@ Juanitoc

Nicely done! I love this script, but that error was becoming a serious nuisance.

@ Guest

To use the fix described above, open up lyricsplugin.vbs, and locate the section of code that Juanitoc is referencing above. I believe that the line beginning " url =" is line 54. Start from there, and anything that Juanitoc has put in bold needs to be changed in lyricsplugin.vbs. The large section in bold (beginning with "If Len(Browser.Interf.LocationURL)") needs to be added to the code. Just paste it in the appropriate spot. Feel free to PM me if you have any questions.

Justin

Vyper · Post by **Vyper** » Sat Feb 23, 2008 8:05 pm

Would someone do an old guy a favor and just repost the whole code with the fix?

spacefish · Post by **spacefish** » Sun Feb 24, 2008 12:22 am

Thank you, Juanitoc! Seems to be working fine here.

Vyper wrote:Would someone do an old guy a favor and just repost the whole code with the fix?

Here ya go

Code: Select all

' Lyrics Plugin Search script
'
' This script is a plug-in into MediaMonkey Web Search dialog. You should save it to Scripts folder as
' lyricsplugin.vbs. It has to be in Scripts.ini file, where entries can be as follows:
'
' [SearchAMG]
' FileName=lyricsplugin.vbs
' ProcName=lyricsplugin
' Order=99
' DisplayName=lyricsplugin
' Language=VBScript
' ScriptType=3

' Global
Dim Browser
Dim Tmr
Dim Current

Sub StartSearch(Panel, SearchTerm, SearchArtist, SearchAlbum)
     Set Browser = SDB.UI.NewActiveX(Panel, "Shell.Explorer")
     Browser.Common.Align = 5 

     Dim Tracks
     Dim Results

     Set Tracks = SDB.Tools.WebSearch.NewTracks
     Set Results = SDB.NewStringList
    
     For i = 0 to Tracks.Count-1
          Results.Add Tracks.item(i).ArtistName & " - " & Tracks.item(i).Title
     Next

     SDB.Tools.WebSearch.SetSearchResults Results
     If Results.Count > 0 Then
          SDB.Tools.WebSearch.ResultIndex = 0
     End If
End Sub

Sub ShowResult(ResultID)
     If (ResultID >= 0)  Then
          Browser.SetHTMLDocument ""

          With SDB.Tools.WebSearch
               .ClearTracksData 
               .TrackChecked(ResultID) = True
               Set Track = .NewTracks.Item(ResultID)
          End With
          
          With Track
               title = .Title
               artist = .ArtistName
          End With
          
          url = "http://www.lyricsplugin.com/plugin/?title=" & title & "&artist=" & artist
          Browser.Interf.Navigate url
          
          Set Tmr = SDB.CreateTimer(40)
          Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
     End If
     
     dim Doc
End Sub

Sub WebsiteLoaded(Timer)
     Script.UnregisterEvents Tmr
     Set Tmr = Nothing

If Len(Browser.Interf.LocationURL) < 10 Then ' A trick - wait until navigation to the search results page starts
Set Tmr = SDB.CreateTimer(40)
Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
Exit Sub
End If

If Browser.Interf.ReadyState = 1 Or Browser.Interf.Busy Then
Set Tmr = SDB.CreateTimer(40)
Script.RegisterEvent Tmr, "OnTimer", "WebsiteLoaded"
Exit Sub
End If 

     Set Doc = Browser.Interf.Document
     If IsObject(Doc) Then
          Set lyrics = Doc.getElementById("lyrics")
          If IsObject(lyrics) Then
               For i = 0 To SDB.Tools.WebSearch.NewTracks.Count - 1
                    If SDB.Tools.WebSearch.TrackChecked(i)  Then
                         SDB.Tools.WebSearch.NewTracks.Item(i).Lyrics = lyrics.innerText
                    End If
               Next
               SDB.Tools.WebSearch.RefreshViews 
          End If
     End If
End Sub

Sub FinishSearch(Panel)
     Browser.Common.DestroyControl      
     Set Browser = Nothing              
End Sub

Vyper · Post by **Vyper** » Sun Feb 24, 2008 9:12 am

Thank you spacefish.

Guest · Post by **Guest** » Tue Feb 26, 2008 1:56 am

nynaevelan wrote:
jn wrote:
nynaevelan wrote:As it is, it is nice but it would be nice to have something a little more automated.
Hm.. I personally dislike everything which runs automatically, as normally that will destroy things
When I say automatically, I mean an option to easily save the tracks without having to keep going into a dialog for individual tracks. For instance, if you take a look at Trixmoto's Batch Album Art script, it gives you a list of all the art for all the tracks which you selected, and you get the option of which ones to save and which ones to skip. The majority of the time I am editing tracks in batch format, and an easier way to do this would be great. Especially since I still have over 1000 tracks which I need to find lyrics for.

Nyn

Please please please add the mass tagging option!! this is all this script requires now

Lyricsplugin Search Script

Re: error message