Page 26 of 34

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Sun Feb 27, 2011 5:06 am
by trixmoto
Because I didn't write "genpuid.exe", MusicIP did... http://musicbrainz.org/doc/genpuid

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Sun Feb 27, 2011 7:16 pm
by Peke
Can you try this app to see if it can generate Short filename for those that fail with script?

http://www.happymonkeying.com/forum/Short_Path.exe

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Mon Feb 28, 2011 8:10 am
by ashenkin
awesome! works!

C:\Users\username\Music\Aaron Neville\Ultimate Collection\Aaron Neville-Aaron Neville - Ultimate Collection-03 - For Your Precious Love.mp3
C:\Users\username\Music\AARONN~1\ULTIMA~1\AARONN~2.MP3

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Mon Feb 28, 2011 7:25 pm
by Peke
Ok Just to confirm that same file do not work with Trix Script.

Trix?

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Mon Feb 28, 2011 9:33 pm
by Kevinowpb
trixmoto wrote:New version (1.8.) is now available to download from my website. Changes include...

- Added extra debug messaging
- Fixed problem with spaces in filenames

Just downloaded... installed... running the Auto Tag from web, and it ZOOMS through 17 (*update... tried randomly on over 1000 files selected 20 at a time individually... then 30.. then 50... all same result..).....---> selected files with NO RESULTS ... 100% Failure.. never saw that before..

Turned the log on... want it? Where is it?

Using Win 7 ultimate.. and MM latest non-beta full release... 3.24 1304

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 4:10 am
by trixmoto
@Peke - all tracks for me for, so I can't really confirm or deny.

@Kevinwpb - the logfile is in your windows temporary directory (%temp%).

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 7:10 am
by Kevinowpb
trixmoto wrote:@Peke - all tracks for me for, so I can't really confirm or deny.

@Kevinwpb - the logfile is in your windows temporary directory (%temp%).
whats it called?

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 1:25 pm
by trixmoto
MIPT.log I think.

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 1:42 pm
by gpzbc
I think MIPT.log is found wherever you designate your MM Temporary Directory to be. You did this in MM "Tools" --> "Options" --> "General"

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 4:24 pm
by SatinKnights
I am reinstalling my machine, and I hit the same "No results found" problem. Since I can do a bit of VBS tweaking, I went looking. It turns out the system was saying "path not found" for something. With blind twiddling, I was able to find it.

Backup the file first. Then edit MusicIPTagger.vbs at line 555.
change
Dim cmd : cmd = "%comspec% /c """&exe&""" f25c7a6acad172541066f475175465a7"
to
Dim cmd : cmd = "%comspec% /c "&exe&" f25c7a6acad172541066f475175465a7"
and it will work in a WinXP environment. (That is what I have) The change removes the quotes around the executable's path as it is being called. If it wasn't a shortpath with no spaces, that would be evil and cause problems. The second instance of the quoted filename for the music file does not need to be changed. It is weird, but it worked. This change may still be dangerous, use at your own risk. I am guessing it will also work with Win7.

-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-

While I am posting, I have a tweak to give back. I was getting annoyed with multi-artist entries coming back as "Kenny Rogers / Dolly Parton" instead of "Kenny Rogers; Dolly Parton" so the following patch will convert to using the ; on the fly.

Code: Select all

--- MusicIPTagger.vbs   2011-03-01 15:46:14.000000000 -0500
+++ MusicIPTagger-new.vbs 2011-03-01 15:59:29.000000000 -0500
@@ -685,6 +685,8 @@
     rel = GetText(trk.getElementsByTagName("first-release-date").Item(0))
     gen = GetText(trk.getElementsByTagName("genre-list").Item(0).ChildNodes.Item(0).ChildNodes.Item(0))
     On Error Goto 0    
+                       Dim newArt
+                       Dim newAArt
     For cnt = 0 To WS.NewTracks.Count-1
       Dim itm : Set itm = WS.NewTracks.Item(cnt)
       If itm.Path = mp3 Then
@@ -701,12 +703,14 @@
         If Not (art = "") Then
           If UpArt Then
             If Debug Then Call out("Artist="&art)
-            itm.ArtistName = art
+                   newArt = art
+            itm.ArtistName = Replace(newArt," / ","; ")
           End If
           If UpAAr Then
             If (itm.ArtistName = itm.AlbumArtistName Or itm.AlbumArtistName = "") Then
               If Debug Then Call out("AlbumArtist="&art)
-              itm.AlbumArtistName = art
+                    newAArt = art
+              itm.AlbumArtistName = Replace(newAArt," / ","; ")
             End If
           End If
           If UpOAr Then
The "-" lines are deletes, the "+" lines are adds. It is a real small tweak, but saves having to go back and manually change the artist and album artist fields. A more organized fix would be to pull the configuration setting for the separator which usually is ';', and specifically use that.

Edit: It looks like the genre could use the same treatment too.
-Satin Knights

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 5:07 pm
by trixmoto
Ok thanks, I'll see what I can do.

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Tue Mar 01, 2011 5:20 pm
by Kevinowpb
does this script work in the beta 4 thats out now?

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Wed Mar 02, 2011 12:39 am
by Kevinowpb
Where in the .vbs file do you put this?

SatinKnights wrote:

Code: Select all

--- MusicIPTagger.vbs   2011-03-01 15:46:14.000000000 -0500
+++ MusicIPTagger-new.vbs 2011-03-01 15:59:29.000000000 -0500
@@ -685,6 +685,8 @@
     rel = GetText(trk.getElementsByTagName("first-release-date").Item(0))
     gen = GetText(trk.getElementsByTagName("genre-list").Item(0).ChildNodes.Item(0).ChildNodes.Item(0))
     On Error Goto 0    
+                       Dim newArt
+                       Dim newAArt
     For cnt = 0 To WS.NewTracks.Count-1
       Dim itm : Set itm = WS.NewTracks.Item(cnt)
       If itm.Path = mp3 Then
@@ -701,12 +703,14 @@
         If Not (art = "") Then
           If UpArt Then
             If Debug Then Call out("Artist="&art)
-            itm.ArtistName = art
+                   newArt = art
+            itm.ArtistName = Replace(newArt," / ","; ")
           End If
           If UpAAr Then
             If (itm.ArtistName = itm.AlbumArtistName Or itm.AlbumArtistName = "") Then
               If Debug Then Call out("AlbumArtist="&art)
-              itm.AlbumArtistName = art
+                    newAArt = art
+              itm.AlbumArtistName = Replace(newAArt," / ","; ")
             End If
           End If
           If UpOAr Then

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Wed Mar 02, 2011 2:36 pm
by SatinKnights
It was a code snippet I was giving back to trixmoto so he could incorporate it into his next release. If you want to modify your own copy right now, here is the explanation. There are two blocks being modified. Line 685 is where the first block starts, with the "rel =" line. The additions are going to be 688 and 689 which are the two "Dim " lines. The second block started at the original 701, which is now line 703. The new 706 line is replaced by the two lines. If you want to do the same for genres, change the
line 734 from
itm.Genre = gen
to
newGenre = gen
itm.Genre = Replace(newGenre,"/","; ")
and add the appropriate
Dim newGenre
back up in the line 689 area.

Caveat: Only try these changes if you are comfortable with writing VBS code. If you don't understand the code, wait for trixmoto to do another release with them incorporated in. It shouldn't be long.

Re: MusicIP Tagger 1.8 - Updated 24/02/2011

Posted: Wed Mar 02, 2011 2:52 pm
by Kevinowpb
This fixed the NO REPLY issue!!
Thanks!

(ps.. I'll wait for Trix's code tweaking for the other genre tweak!!

Thanks x2!

SatinKnights wrote: change
Dim cmd : cmd = "%comspec% /c """&exe&""" f25c7a6acad172541066f475175465a7"
to
Dim cmd : cmd = "%comspec% /c "&exe&" f25c7a6acad172541066f475175465a7"