Page 2 of 3
Re: Strange bug affecting search results
Posted: Mon Feb 28, 2022 1:48 pm
by Ludek
Thanks for reporting,
I can't replicate 'rolling' not find any albums by 'The Rolling Stones'
But I can replicate what user tbm72 reported here:
https://www.mediamonkey.com/forum/viewt ... 48#p495048
i.e. 'The H' does not find 'The Human League'
Sounds like a regression introduced in 2609 while fixing #18863
To be fixed as
https://www.ventismedia.com/mantis/view.php?id=18883
Re: Strange bug affecting search results
Posted: Tue Mar 01, 2022 2:58 am
by Barry4679
Ludek wrote: ↑Mon Feb 28, 2022 1:48 pm
I can't replicate 'rolling' not find any albums by 'The Rolling Stones'
I am concerned that you may not have addressed the whole problem.
When you tested did you have Filter setting to Ignore Diacritics and Match whole words only?
Or change to Ignore Diacritics and Match beginning of words. This means that criteria such as rolli won't find The Rolling Stones either.
Am concerned that if you were unable to replicate what was reported, then there is no certainty that you have fixed it.
Re: Strange bug affecting search results [#18883]
Posted: Tue Mar 01, 2022 3:22 am
by tbm72
To confirm what Barry4679 says, I also get no results for The Rolling Stones when using 'Ignore diacritics/Search whole words only (faster)' and type. 'The Rolling'.
Re: Strange bug affecting search results [#18883]
Posted: Tue Mar 01, 2022 2:44 pm
by Ludek
Yes, 'The Rolling' was broken in 2609, i.e. when there was a space used.
This is already fixed for 2610
Re: Strange bug affecting search results [#18883]
Posted: Tue Mar 01, 2022 3:17 pm
by Rob_S
Great, looking forward to it.
I hope it will find all my Irish Rovers again!!!
Re: Strange bug affecting search results [#18883]
Posted: Wed Mar 02, 2022 9:24 pm
by Barry4679
Ludek wrote: ↑Tue Mar 01, 2022 2:44 pm
Yes, 'The Rolling' was broken in 2609, i.e. when there was a space used.
This is already fixed for 2610
Yes but does it fix it for rolling ... ie. no space in the filter criteria
it seems to me that there is a bug in 2609 that has broken the filtering in the following situation:
- search option is either of the IGNORE Diacritics options
- and it is the AlbumArtist or Artist tag which contains the matches
- and the tag starts with the word "The"
ie
roll does not find
The Rolling Stones . same thing with rolling
beat does not find The Beatles .... same thing with beatles ... but does find the album Beatles For Sale
but
grat finds all of the Grateful Dead ok .... same thing with grateful .... both work OK
ie. the bug I am reporting isn't related to spaces AFAICS ... it is related to "
The",
and the album & albumartist tags
and the Ignore Diacritic sort option (which is the MM5 default)
nb: I am still on 2609
Re: Strange bug affecting search results [#18883]
Posted: Wed Mar 02, 2022 10:26 pm
by Rob_S
First of all I don't have any rolling stones to confirm this with.
I have 204 The Irish Rovers and 2 Irish Rovers in the Artist field all of which can be found in MM4 by typing Irish Rovers or Rovers
The same searches in MM5 2608 finds them all as well.
The same searches in MM5 2609 same default setting (ignore, match beginning) finds only 26 of them. The column filter in this same version finds all of them, under the two different names.
(Ignore, match whole) only finds the two that are missing "The "
So it appears that having The in front only matters some of the time
Re: Strange bug affecting search results [#18883]
Posted: Thu Mar 03, 2022 1:50 am
by Barry4679
Rob_S wrote: ↑Wed Mar 02, 2022 10:26 pm
The same searches in MM5 2609 same default setting (ignore, match beginning) finds only 26 of them. The column filter in this same version finds all of them, under the two different names.
(Ignore, match whole) only finds the two that are missing "The "
So it appears that having The in front only matters some of the time
I have re-worked my theory:
it (now) seems to me that there is a bug in 2609 that has broken the filtering in the following situation:
- search option is either of the IGNORE Diacritics options
- and the tag starts with the one of those prefix words, eg."The"
What happens that the tags are entirely invisible to the filter if they start with one of the trigger prefixes.
eg. I have all albums by The Beatles, but filter criteria of
beatles only finds one of them
ie. "The Beatles" in the Artist and AlbumArtists tags are currently invisible to the filter mechanism, but an album title of "
Beatles For Sale" is visible to it. .... If the album title was "THE Beatles for Sale" I am betting that it would be invisible also.
eg 2: I have album whose title is "
The Live Adventures Of Mike Bloomfield And Al Kooper"
It cannot be found with filter
live
But "
Live at
THE Matrix" by "
THE Doors" can be found, because live can be found in a tag where it is not preceded by
the.
Does that account for your 26 successful Irish Rovers hits?
For the 26 matches you got,
- is the word Rovers in any tag that does not start with The, or whatever trigger words you have configured for?
Re: Strange bug affecting search results [#18883]
Posted: Thu Mar 03, 2022 8:08 am
by Ludek
FYI: Yes, there has been a regression in 2609 already fixed in 2610.
e.g.
https://www.ventismedia.com/mantis/view.php?id=18883 and
https://www.ventismedia.com/mantis/view.php?id=18888
(both the same fix/regression)
So once it works in 2608 there is 100% probability that it works in 2610 too.
No result for search
Posted: Fri Mar 04, 2022 8:31 am
by Jaani
I have two tracks with the following names:
1: Reza Pishro - Coma (Ft. AvA, Ali Owj and Shahin Felakat).mp3
Title: Coma (Ft. AvA, Ali Owj and Shahin Felakat)
Artist(s): Reza Pishro
2: Hichkas & Reza Pishro - Bazam Kalan.mp3
Title: Bazam Kalan
Artist(s): Hichkas & Reza Pishro
When I search for Pishro or Reza Pishro, those tracks will not be among the results. But If I search for Coma or Hichkas they will.
Build 2609
Re: Strange bug affecting search results [#18883]
Posted: Fri Mar 04, 2022 10:54 am
by Lowlander
As Search has a bug on 2609 please retest on 2610 when it's released. Also mention what
Search Mode you've set if it still fails on 2610.
Re: Strange bug affecting search results [#18883]
Posted: Fri Mar 04, 2022 11:04 am
by Rob_S
Is 2610 available for testing, I don't see it anyplace yet???
Re: Strange bug affecting search results [#18883]
Posted: Fri Mar 04, 2022 12:05 pm
by Lowlander
Re: Strange bug affecting search results [#18883]
Posted: Fri Mar 04, 2022 9:15 pm
by Barry4679
Is published now, and it fixes all of the filtering anomalies that I was reporting.
There is still one smaller problem that I thought was the same thing, but apparently isn't.
Filtering in one tab can affect a non-related tab. I still see that, but will report it separately. It is a comparatively minor issue.
Re: Strange bug affecting search results [#18883]
Posted: Fri Mar 04, 2022 10:15 pm
by Rob_S
Yes, indeed, seems all fixed for me as well.
Thanks, Guys!!!