1207 Quick search fails on [, ] and ! [5134]

Post a reply

Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:

BBCode is ON
[img] is ON
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: 1207 Quick search fails on [, ] and ! [5134]

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by chrisjj » Mon Jan 12, 2009 7:19 am

> I think the following above indicates which characters are omitted:
> ('/','\','?',',','|',':','.','_','(',')','[',']','&','@','#','+','*','!','-',';')

It doesn't (assuming by "omitted" you mean ignored) e.g. Vol 1 & 2 and Vol 1 2 here (1209) give different results.

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by chrisjj » Mon Jan 12, 2009 7:05 am

> I believe Rusty stated it above:

He stated it for 1207. I'm asking for 1209, the behaviour of which does not accord with Rusty's statement.

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by Lowlander » Sun Jan 11, 2009 10:41 pm

I think the following above indicates which characters are omitted:
Nevertheless per discussion with Jiri over IM we could switch to the old search (we had in MM 3.0) in the case when only a single special char is typed to search bar('/','\','?',',','|',':','.','_','(',')','[',']','&','@','#','+','*','!','-',';')

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by nohitter151 » Sun Jan 11, 2009 10:40 pm

chrisjj wrote:I'm getting rather exhausted by this guessing game. Could someone please direct me to the docs saying what the 1209 search is actually supposed to do?
I believe Rusty stated it above:
rusty wrote:I think, that the current behavior makes sense:
a) Search for 'special character' --> special character is found
b) Search for 'special character' appended to other text --> special character is ignored
c) Search for 'special character' appended to other text all in quotation marks --> special character isn't ignored (an exact match must be found)

Regarding b), I tried out a couple of search engines, and it seems that special characters are generally ignored when doing full-text searches. However, as to whether this makes the most sense for MediaMonkey users, I'm not sure. Like ChrisJJ pointed out, there was only one complaint about it at http://www.mediamonkey.com/forum/viewto ... =6&t=34710 . On the other hand, the current implementation gives more flexibility since users can search for "B.B. King" or Trad. and get results. At the same time, I'm sure that many users won't even think to use Quotes and will wonder why a search for :30 isn't returning the expected results.

-Rusty

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by Lowlander » Sun Jan 11, 2009 10:36 pm

As indicated a few times before there are no docs yet!

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by chrisjj » Sun Jan 11, 2009 10:34 pm

I'm getting rather exhausted by this guessing game. Could someone please direct me to the docs saying what the 1209 search is actually supposed to do?

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by Lowlander » Sun Jan 11, 2009 10:27 pm

It works for me search for "yo!" only shows yo! not yo.

Re: 3.1.0.1207 Quick search fails on [, ] and !

by chrisjj » Sun Jan 11, 2009 8:45 pm

> We decided to add proper full-text search engine so that quick searching would be faster on large DBs and it really is.

I have no problem with you adding a proper search engine, and/or speeding up searches. The problem I'm reporting is that you broke the existing search.

> Nevertheless if you want to search for help! you can, just type: "Help!"

Unfortunately that now (1209) does not work properly either - it false-matches "Help".

Re: 3.1.0.1207 Quick search fails on [, ] and ! [Bug 5134]

by Lowlander » Tue Jan 06, 2009 8:30 pm

I would actually hope that help! would also find help. The whole idea of full text search is that you get similar matches so that you don't need to know the exact value. I think the suggestion to just allow single character search and ignore if multiple characters are entered is a good one.

Re: 3.1.0.1207 Quick search fails on [, ] and !

by rusty » Tue Jan 06, 2009 6:19 pm

I think, that the current behavior makes sense:
a) Search for 'special character' --> special character is found
b) Search for 'special character' appended to other text --> special character is ignored
c) Search for 'special character' appended to other text all in quotation marks --> special character isn't ignored (an exact match must be found)

Regarding b), I tried out a couple of search engines, and it seems that special characters are generally ignored when doing full-text searches. However, as to whether this makes the most sense for MediaMonkey users, I'm not sure. Like ChrisJJ pointed out, there was only one complaint about it at http://www.mediamonkey.com/forum/viewto ... =6&t=34710 . On the other hand, the current implementation gives more flexibility since users can search for "B.B. King" or Trad. and get results. At the same time, I'm sure that many users won't even think to use Quotes and will wonder why a search for :30 isn't returning the expected results.

-Rusty

Re: 3.1.0.1207 Quick search fails on [, ] and !

by Ludek » Tue Jan 06, 2009 10:25 am

Chriss, I don't even see a complaint that MM searchs help if help! is typed. This is simply how full text search engines works. i.e. if you search for help! in google you get help in results too. We decided to add proper full-text search engine so that quick searching would be faster on large DBs and it really is. i.e. text values are indexed in DB (in SongsText) table.

Nevertheless if you want to search for help! you can, just type: "Help!"
i.e. quote it

Re: 3.1.0.1207 Quick search fails on [, ] and !

by chrisjj » Tue Jan 06, 2009 9:54 am

says:
Nevertheless per discussion with Jiri over IM we could switch to the old search (we had in MM 3.0) in the case when only a single special char is typed to search bar('/','\','?',',','|',':','.','_','(',')','[',']','&','@','#','+','*','!','-',';')
That's not sufficient. It won't fix the fact that searching for Help! erroneously finds Help. Please would you just restore the 3.0 functionalilty? I didn't see anyone complaining about it. And If really there has to be a behaviour that ignores an arbitrary set of characters, please make it a special mode. And please document the list of characters it ignores. Thanks.

Re: 3.1.0.1207 Quick search fails on [, ] and !

by chrisjj » Tue Jan 06, 2009 9:50 am

It says
Typing just the character ! into the quick search box, the tracklist goes blank, failing to show the tracks here having ! in searched fields.

Currently this is in contradiction with 0005004 (Full-text-search: characters such as '.' should be removed from the query) and how full text search engines (like Google too) mostly works.
but sorry Ludek that claim of contradiction is in error and I really think this entry should be corrected rather than being left to cause confusion over what the issue really is.

FOAD, I'm saying the behaviour I reported does NOT contradict "Full-text-search: characters such as '.' [are] removed from the query". It accords.

Re: 3.1.0.1207 Quick search fails on [, ] and !

by Ludek » Tue Jan 06, 2009 8:59 am

Re: 3.1.0.1207 Quick search fails on [, ] and !

by chrisjj » Tue Jan 06, 2009 8:53 am

Ludek wrote:currently it is in contradiction with http://www.ventismedia.com/mantis/view.php?id=5004
Assuming you mean the observed behaviour is by design, could you please refer me to to docs? I'd like to know what characters are now unavailable.

> and how full text search engines (like Google too) works.

No, Google does not do "characters like '.' should be removed from full-text query" as per http://www.ventismedia.com/mantis/view.php?id=5004 .

e.g. compare http://www.google.co.uk/search?hl=en&q=help! with http://www.google.co.uk/search?hl=en&q=help

Top