Event OnChangedSelection between nodes

Post a reply

Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:
BBCode is ON
[img] is ON
[url] is ON
Smilies are ON
Topic review
   

Expand view Topic review: Event OnChangedSelection between nodes

Re: Event OnChangedSelection between nodes

by ZvezdanD » Mon Apr 05, 2010 5:56 am

Oh well. You MM developers are not serious and don't respect your scripters at all. I mean, it is great if you decide to implement suggestions of some scripters, even if they are breaking compatibility with some existing scripts, but I expect at least to see some public information about that. You didn't mention anywhere that you changed OnChangedSelection behavior with 3.1.0.1251. even not in the wiki. I spent several hours trying to find what is wrong with my script with the latest MM version, knowing that it worked fine with older MM versions.

Well, now I know that OnChangedSelection is generated only once when some node changed, but it is very discussable if you should generate that event before (as it is now implemented) or after some node is changed. I expect in my event handler that it is generated after the current node is already changed, not before. Well, if you want to be really attentive, you should add one more event, let say OnChangingSelection, which should be generated before some node is changed.

Re: Event OnChangedSelection between nodes

by Teknojnky » Mon Feb 09, 2009 5:27 pm

Not sure what problems it could cause by fixing, but I know that it would help avoid problems caused by a script being called multiple times when it does not have some time type of mutex to ensure that it not called multiple times in rapid succession for what should be a single event.

see also

http://www.mediamonkey.com/forum/viewto ... =2&t=36256

Re: Event OnChangedSelection between nodes

by jiri » Thu Feb 05, 2009 12:49 pm

This is caused by the way how events are handled internally in MM. So, unless it causes serious problems in some cases (please describe, if you have an example), I'd prefer not fixing this, since it could introduce other problems, particularly for already existing scripts.

Jiri

Re: Event OnChangedSelection between nodes

by MoDementia » Sat Jan 24, 2009 4:39 pm

Not in Mantis

Save as OnSelection.vbs in Scripts\Auto\

Code: Select all

Sub OnStartup
      Script.RegisterEvent SDB, "OnChangedSelection","OnSelection"
End Sub

Sub OnSelection
      SDB.MessageBox "Onselection Triggered", mtError, Array(mbOk)
End Sub

by MoDementia » Thu Apr 17, 2008 9:34 am

Cheers

by jiri » Thu Apr 17, 2008 3:44 am

In order to not cause more bad than good just before 3.0.3 release, I'd rather leave this as is, but we will look into it for the future versions.

Jiri

Event OnChangedSelection between nodes

by MoDementia » Mon Mar 24, 2008 12:19 am

Maybe not a bug but certainly inefficient

Changing from 1 node to the other i.e. from artist & album artist to album artist

Selected sequence

First track in AAA
First track in AAA
First track in AAA
First track in AA

Triggered 4 times for what is effectively 1 changed selection (maybe 2 if you count the node)

then within the track list changing selection results in

First track
First track
New track

After that it is just 1 per selection change.

I just had a message pop up every time the event was triggered displaying artist

I thought my script was looping some how but now think the event is getting triggered too many times

Top