1249 Some tools wrongly disabled for Now Playing [#5737]

Beta Testing for Windows Products and plugins

Moderator: Gurus

chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

1249 Some tools wrongly disabled for Now Playing [#5737]

Post by chrisjj »

[EDIT:]

1 Launch MM
2 Click a Now Playing track
3 Click a Track List track
4 Click Now Playing title bar
5 Press ALT-T - see first three Tools menu commands are enabled
6 Click a Tree node
7 Click Now Playing title bar
EDIT: 8 Press ALT-T

Expected: first three Tools menu commands are enabled
Observed: disabled.

Note: docked/floating-ness of Now Playing makes no difference.

http://www.mediamonkey.com/forum/viewto ... &sk=t&sd=a is fixed so presumably not related.
Chris
rusty
Posts: 9057
Joined: Tue Apr 29, 2003 3:39 am
Location: Montreal, Canada

Re: 1249 Some tools disabled for floating Now Playing -------

Post by rusty »

chris,

I can't reproduce this in 1250 in skinless mode.

Any other hints?

Thx.

-Rusty
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1249 Some tools disabled for floating Now Playing -------

Post by chrisjj »

> Any other hints?

Now traced to the previous focus owner - OP updated.
Chris
rusty
Posts: 9057
Joined: Tue Apr 29, 2003 3:39 am
Location: Montreal, Canada

Re: 1249 Some tools wrongly disabled for Now Playing ------

Post by rusty »

Ludek
Posts: 5122
Joined: Fri Mar 09, 2007 9:00 am

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by Ludek »

chrisjj wrote:[EDIT:]

1 Launch MM
2 Click a Now Playing track
3 Click a Track List track
4 Click Now Playing title bar
5 Press ALT-T - see first three Tools menu commands are enabled
6 Click a Tree node
7 Click Now Playing title bar

Expected: first three Tools menu commands are enabled
Observed: disabled.

Note: docked/floating-ness of Now Playing makes no difference.

http://www.mediamonkey.com/forum/viewto ... &sk=t&sd=a is fixed so presumably not related.
This is not a bug, if you click a tree node then the tracks from the node should activate the menu. If there aren't any then the menu isn't activated until you re-select the tracks from Now Playing.
rusty
Posts: 9057
Joined: Tue Apr 29, 2003 3:39 am
Location: Montreal, Canada

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by rusty »

If there aren't any then the menu isn't activated until you re-select the tracks from Now Playing.
That was actually the bug--selecting the tracks by selecting the titlebar previously (prior to build 1251) didn't work 100% correctly. In build 1251, the fix to issue 2 of http://www.ventismedia.com/mantis/view.php?id=5737 seems to have resolved this particular issue.

-Rusty

[EDIT (Rusty): changed 'selecting the toolbar' to 'selecting the titlebar']
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by chrisjj »

> This is not a bug ... the menu isn't activated until you re-select the tracks from Now Playing.

Surely #7 is reselecting tracks from Now Playing. If you mean the user has to click on them again, then it does to me sound as if there is a bug.
Chris
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by chrisjj »

> That was actually the bug--selecting the tracks by selecting the toolbar previously (prior to build 1251) didn't work 100% correctly.

You've lost me there Rusty, esp. with the bit about a toolbar.

> In build 1251, the fix to issue 2 of http://www.ventismedia.com/mantis/view.php?id=5737

That does not look like the same issue to me.

> seems to have resolved this particular issue.

Not here - the original issue remains in 1251.
Chris
rusty
Posts: 9057
Joined: Tue Apr 29, 2003 3:39 am
Location: Montreal, Canada

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by rusty »

> That was actually the bug--selecting the tracks by selecting the toolbar previously (prior to build 1251) didn't work 100% correctly.

You've lost me there Rusty, esp. with the bit about a toolbar.
I meant to say that "selecting the tracks by selecting the _NP titlebar_'...didn't work 100% correctly. i.e. at step 7, you are causing the tracks in NP to be selected, by clicking the NP Titlebar. Previous to 1251, the Tools menu didn't recognize that the tracks were selected, but in build 1251, the Tools menu does recognize that the tracks are selected and the commands are no longer disabled (at least for me--I just re-verified both issues in bug #5737).

I don't know why, but for some reason, a variety of NP Selection issues seem to be occurring for you (and I'm testing with NP undocked) :(

-Rusty
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1249 Some tools wrongly disabled for Now Playing [#5737]

Post by chrisjj »

> I meant to say that "selecting the tracks by selecting the _NP titlebar_'

Ah, got you.

> in build 1251, the Tools menu does recognize that the tracks are selected and the commands
> are no longer disabled (at least for me--I just re-verified both issues in bug #5737).

Still the issue remains for me in 1251 (skinless, SP2).
Chris
Post Reply