1250 Tag edit can lose external File Monitored edits [#2609]

[chrisjj]

1 In Mp3tag change the album tags of 500 tracks in an MM File Monitored folder.
2 Switch to MM and soon change some rating on those tracks

Expected: #1 changes intact
Observed: Some #1 changes lost

I'd guess this is due to a race hazard - the MM tag edit operation at #2 is sourcing from the library without first checking that info is up-to-date from the File Monitor at #1.

[Eyal]

That is just playing cat and mouse.

[chrisjj]

MM = cat, user data = mouse ??

[rusty]

Added to http://www.ventismedia.com/mantis/view.php?id=2609

-Rusty

[jiri]

I don't think there can be anything done against this, if two edits of the same file occurs almost simultaneously in two applications, the last edit will 'win'. That's definitely true for Properties dialog, when you confirm (by pressing OK button) all tag changes. I can see the point that changing a single field (like rating) would not modify other fields, but it currently isn't possible, MM always updates the whole tag.

Jiri

[chrisjj]

> I don't think there can be anything done against this,

Won't the suggested "first checking that info is up-to-date from the File Monitor" solve it?

> if two edits of the same file occurs almost simultaneously in two applications, the last edit will 'win'.

That's fine by me. If the user has performed both manually then however fast he switched apps. he expects the last to win.

But that is not the case reported. The case reported does not require almost simultaneous, and the problem is that the edit that wins is the first, not the last.

[chrisjj]

> Added to http://www.ventismedia.com/mantis/view.php?id=2609

That Mantis issue very much looks like a distinct issue.

[rusty]

> Added to http://www.ventismedia.com/mantis/view.php?id=2609

That Mantis issue very much looks like a distinct issue.

It is a unique bug, but I think that there's a single solution for both issues (i.e. a single queue that tracks changes to metadata from within MM and from without).

-Rusty

[chrisjj]

> I think that there's a single solution for both issues (i.e. a single queue that tracks changes to metadata from within MM and from without).

OK, but I can see that being tricky. Users might not accept rating change being barred/delayed for the duration of a File Monitoring.

Good luck!