1345: Search issues [#7253]

[Lowlander]

This is all done using Entire Library from the Quick Search bar

1) Search node isn't expanded to show the current search when searching

2) Quick Search doesn't remember past searches, so past search drop-down shows empty when typing


3) I was able to right click on a search node that wasn't selected without selecting it. Many of the options in the context menu like Remove were disabled.
a) Select some non-search node
b) Click in Quick Search textbox
c) Right click on a search result node


4) When removing searches from Search node leaving it empty it still shows, I think it might be nice it auto-hides when it has no searches and isn't selected.

Tested on skinned 1345 on XP. Can anyone confirm any of these issues?

[Mizery_Made]

1) Search node isn't expanded to show the current search when searching

Confirmed. Note that having it expanded and then running a search can sometimes close the Search Results node as well.

2) Quick Search doesn't remember past searches, so past search drop-down shows empty when typing

Not seen here when Enter is pressed after typing the search, which is the same behavior as MM3.

3) I was able to right click on a search node that wasn't selected without selecting it. Many of the options in the context menu like Remove were disabled.
a) Select some non-search node
b) Click in Quick Search textbox
c) Right click on a search result node

I can't reproduce this here. When I right click a search node, it selects the node (which fails against the new behavior of right clicking nodes without selecting) and then displays the correct menu.

4) When removing searches from Search node leaving it empty it still shows, I think it might be nice it auto-hides when it has no searches and isn't selected.

This has been requested before. I suppose it makes some sense.

[Lowlander]

2) You're right, my mistake. When hitting Enter it does remember.

3) You need to follow the specific steps to reproduce, as otherwise it does work as expected (although unwanted).

[Mizery_Made]

3) I believe I am following your steps correctly. I'll focus a non-search node (such as Artist & Album Artist), then click into the search box, followed by right clicking on a search node that I previously ran. The result for me is the search node getting selected and the proper context menu appearing.

[Lowlander]

3) Can you confirm for me if it fails on the first search entry (top most)? It seems to only fail on the first here.

The others will show a delay in showing context menu options. When opened it shows many items as disabled, but then changes them to enabled while switching highlight to node. It seems to wait to load the Tracklisting before enabling various of the context menu items. Without clicking in the search bar the context menu loads immediately with all items enabled.

[Mizery_Made]

Bingo, I was finally able to reproduce. The key (here at least) isn't that it has to be the top most search node, instead I find that it has to be an empty search node. I also find that the step of clicking into the Search box isn't the exclusive way to do this. You can click a node, click one of the tracks in said node (thus taking focus away from the tree) and then right click the (empty) playlist node and you get the same behavior you're describing.

EDIT: Going from Non-Search node, to Now Playing track, to Search node has options enabled, but Remove attempts to remove NP track instead of Search node. I think this and similar issues may all be children of the "Right Click, but Non-Select" feature not being properly implemented.

[Lowlander]

Yes, it is an issue with empty search results. I also see the issue with NP track being removed instead of search node.

[Lowlander]

Thanks for confirming. Added as: http://www.ventismedia.com/mantis/view.php?id=7253