1396: MM4 crashs, if a song is edited in microplayer [#8033]

[A User]

Hello guys,

while playing around with MM4, I found MM4 raising an exception in the following situation:

1. Switch MM4 to microplayer mode.
2. Hover the mouse over microplayer. -> songinfo panel pops up
3. Click on playlist button on songinfo panel. -> playlist control is shown on top of the songinfo panel
4. Click a song to select it.
5. Click the song again to edit e.g. its tilte.

As soon as the edit control is shown, to edit the song title inplace, an error dialog is shown with the message "no parent control".

Btw.: I sent a BUG report using MM4s auto bug reporting feature.

I am using Pulse skin, in case it matters.

greets, and good luck for bug hunting

[nohitter151]

I can't reproduce at all, I can't edit at all from that view.

[A User]

Hi nohitter151,

I tried it several times with always the same result. I even changed the skin to Vitrous. To reproduce, simply wait about 2 or 3 seconds between step 4 and 5. Clicking onto a track in the playlist popup window will start the inplace edit, which causes the error Control '' has no parent window. After MM4's main window is restored, the edit control is still visible in the playlist. Clicking into the playlist then, causes 4 AVs with a read of address 0.

Here ist the call stack of the bugreport produced by starting the inplace edit in the playlist popup. I think this proves my monitorings

Code: Select all

Call Stack Information:
------------------------------------------------------------------------------------------------------
|Address |Module         |Unit              |Class           |Procedure/Method            |Line      |
------------------------------------------------------------------------------------------------------
|*Exception Thread: ID=1556; Priority=0; Class=; [Main]                                              |
|----------------------------------------------------------------------------------------------------|
|004EF046|MediaMonkey.exe|Forms.pas         |                |ValidParentForm             |2245[3]   |
|004EEFE4|MediaMonkey.exe|Forms.pas         |                |ValidParentForm             |2242[0]   |
|0051F562|MediaMonkey.exe|Controls.pas      |TWinControl     |SetFocus                    |12038[7]  |
|009418A9|MediaMonkey.exe|VTEditors.pas     |TCustomEditLink |BeginEdit                   |368[8]    |
|00A9499A|MediaMonkey.exe|VirtualTrees.pas  |TBaseVirtualTree|DoEdit                      |22637[25] |
|00A9114C|MediaMonkey.exe|VirtualTrees.pas  |TBaseVirtualTree|WMTimer                     |20826[7]  |
|00516313|MediaMonkey.exe|Controls.pas      |TControl        |WndProc                     |7232[91]  |
|00515FB4|MediaMonkey.exe|Controls.pas      |TControl        |WndProc                     |7141[0]   |
|0051BAA8|MediaMonkey.exe|Controls.pas      |TWinControl     |WndProc                     |10015[144]|
|0051B4E4|MediaMonkey.exe|Controls.pas      |TWinControl     |WndProc                     |9871[0]   |
|00A9F674|MediaMonkey.exe|VirtualTrees.pas  |TBaseVirtualTree|WndProc                     |28025[32] |
|0051B070|MediaMonkey.exe|Controls.pas      |TWinControl     |MainWndProc                 |9731[3]   |
|00447314|MediaMonkey.exe|Classes.pas       |                |StdWndProc                  |13164[8]  |
|00406020|MediaMonkey.exe|System.pas        |                |FindDynaMethod              |9832[1]   |
|00406054|MediaMonkey.exe|System.pas        |                |_CallDynaInst               |9885[4]   |
|76967885|USER32.dll     |                  |                |DispatchMessageW            |          |
|7696787B|USER32.dll     |                  |                |DispatchMessageW            |          |
|004FDEEF|MediaMonkey.exe|Forms.pas         |TApplication    |ProcessMessage              |10039[30] |
|004FDD90|MediaMonkey.exe|Forms.pas         |TApplication    |ProcessMessage              |10009[0]  |
|004FDFC3|MediaMonkey.exe|Forms.pas         |TApplication    |HandleMessage               |10091[1]  |
|004FDFB4|MediaMonkey.exe|Forms.pas         |TApplication    |HandleMessage               |10090[0]  |
|004FE367|MediaMonkey.exe|Forms.pas         |TApplication    |Run                         |10228[26] |
|004FE294|MediaMonkey.exe|Forms.pas         |TApplication    |Run                         |10202[0]  |
|00B5CAF6|MediaMonkey.exe|MediaMonkey.dpr   |                |                            |503[177]  |
|76A633C8|kernel32.dll   |                  |                |GetEnvironmentVariableA     |          |
|----------------------------------------------------------------------------------------------------|

[nohitter151]

It doesn't let me edit at all in 1397.

[Lowlander]

In place editing doesn't work here either on 1397.

[A User]

Very strange. As often I try, I can. No matter what I try, I can inplace edit resulting in the descriped error. I must have another built #1397.

I disabled all scripts and reset settings to defaults by deleting the mediamonkey.ini.

Maybe something I forgot: I always played a song before I try.

[Lowlander]

Maybe a screenshot of where exactly you're able to edit helps. Also check Help > About to verify you're using 1397.

[A User]

Here is the asked screenshot of the playlist popup with inplace edit started and the resulting error dialog.



Maybe another hint to find the bug. I was able to reproduce the bug after some tries. I started MM4. The MainForm was visible. I switched to MicroPlayer without touching anything else. There were songs in the playlist at this time. I hovered the micoplayer to open the songinfo panel and opened the playlist, too. At this time I was not able to inplace edit anything. So I started playback and tried again. No luck, too.

Then I restored the MainForm, selected another song in the playlist and started playback by doubleclick. Afterwards I switched back to MicroPlayer and tried to edit a song in the playlist inplace. This time the edit control was shown and the exception was raised.

If I now restore the MainForm, the inplace edit control is still visible in the playlist control. If I click anywere in the playlist to stop inplace editing an AV is raised (Access violation at address 00000000. Read of address 00000000). This happens for about 4 or 5 times and afterwards anything is OK again.

P.S.: Trying all that stuff I found the songinfo panel is not always shown, If I hover over the MicroPlayer control.

[Lowlander]

Even switched to the Pulse skin, but on 1397 I can't edit in place. Neither F2 nor slow double click allow it here.

[nohitter151]

A User: please upgrade to latest build and tell us if it still occurs. We cannot edit in place at all here in the latest build.

[rusty]

Thanks--I'm able to reproduce. Tracked at: http://www.ventismedia.com/mantis/view.php?id=8033

The reason LL/nohitter didn't reproduce is most likely because the Now Playing Window was displaying the 'Summary' field which isn't editable.

-Rusty

[nohitter151]

The reason LL/nohitter didn't reproduce is most likely because the Now Playing Window was displaying the 'Summary' field which isn't editable.

Actually, I had thought of that and enabled the title and date fields, but I still could not edit there.

[Lowlander]

No, Summary field is disabled here.

[A User]

Ok, I tried with built 1398. The BUG is fixed. I am no longer able to edit inplace.

p.s.: Sorry for finding hard to find BUGs.

[A User]

... but never the less. I tried serveral tools to manage my music collection, but MediaMonkey is far the best. It is the most flexible, very fast compared to other tools and its memory footprint is quite ok respecting what complex functionality it provides.

So lets hunt the last BUGs to get a perfect release