[bug#8551] Menubar aligned without border

[A User]

Hello guys, maybe i am the only one with this issue again, but since built 1345 the menubar (shown in the titlebar) is displayed without any space between the screen border and the text, if the window is maximized. This looks a bit shady.
The selected skin does not have any influence on this issue.

I took a screenshot for illustration:


Please fix it.

[Lowlander]

Are you on 1346 or 1446?

[nohitter151]

Not reproducible here. Is it language specific?

[A User]

Seems not to be language specific. Same happens with language set to english, too.

I found out the following situations causing the issue:
1. Setting ShowMainMenu=0
Menubar is always aligened to top without border. Opening the menu even causes the whole toolbar to be redrawn, which seems to be quite slow and causes some flickering.

2. ShowMainMenu=1 and AlwaysShowTabs=0
Menubar seems to be aligened correctly until the last TAB is closed and no more tabs are shown.
Even though, the menubar seems not to be vertically centered to the application icon in any situation.

The size of the titlebar and menubar changes significantly, when maximizing MediaMonkey.

[nohitter151]

Seems not to be language specific. Same happens with language set to english, too.

I found out the following situations causing the issue:
1. Setting ShowMainMenu=0
Menubar is always aligened to top without border. Opening the menu even causes the whole toolbar to be redrawn, which seems to be quite slow and causes some flickering.

2. ShowMainMenu=1 and AlwaysShowTabs=0
Menubar seems to be aligened correctly until the last TAB is closed and no more tabs are shown.
Even though, the menubar seems not to be vertically centered to the application icon in any situation.

The size of the titlebar and menubar changes significantly, when maximizing MediaMonkey.

I still can't reproduce it, regardless of settings. Anything else you can think of?

[A User]

As I guess It has something to do with border handling of AERO, I disabled AERO and reanabled it. This way I at least partly solved the issue. The problem is, I am using a custom windows skin. But due to automatic update the patched themeui.dll was overwritten by a none patched. The theme still was displayed correctly, but the borders of maximized windows seemed to be calculated not correctly. I repatched the new file with the following result:



But there is still the issue that the menu is not alligend vertically centered to the application icon, if the window is maximized. I think, it would look better, if the menu was aligned vertically centered to the application icon in both normal and maximized state.

[nohitter151]

So you're using a patched uxtheme.dll file, I guess that's the issue. Not really a bug, then.

[Guest]

I'm not sure, whether this issue is caused by patched themeui.dll. MM4 is the ONLY application with such graphic glitches. All other applications, even those using the titlebar to display menubars etc. work perfectly good. On the other hand, the patch does only enable me to use none signed alternate themes, as Microsoft is not able to provide some. I do not change any system resources etc.. Even with default windows aero theme, the issue exists.

I was unfortunatelly wrong with my last post. As soon as I disable the TAB-control, the menubar looks like in my first post again. But I think I have an idea of the reason:

If you have a look on the following screenshot compared to the one of my last post, you can see, there is no space below the "Minimize/Maximize/Close" buttons here. On the other hand there seems to be a fixed space between the menubar and the bottom border of the titlebar. As the titlebar's height is too small, if the window is maximized and no TAB-controls are displayed, the menubar is aligned to e.g. -4px , which causes it to be cut off. Means, you need to ensure, the titlebar height of MM4 is equal under all circumstances. At the moment, the titlebar height seems to change in several situations.

If I have a look at my Opera browser's tiltebar, the space between the "Minimize/Maximize/Close" and the bottom border of the titlebar does not change, no matter the browser window is maximized or not.

[A User]

Aaahh.

Purely by chance, I just found the reason for this issue - it's MM3/MM4's most annoying graphical bug. The issue is caused by MM's unability to adapt to custom font sizes, but I think I posted this bug in the past.

I set up 14px font size in order to be able to read anything. If I return to 100% font size, the menubar is not cut off. As soon as font size is enlarged, the menu is cut off, if the window is maximized.

I think a correct font handling, must be one of the most important tasks in the next version of MM. The default font size of 11px is too tiny on a modern FullHD monitor, even on a 24". It must be possible to enlarge the fonts without the annoying graphical issues, which exist in several dialogs and controls.

Thanks.

[nohitter151]

Yes, thank you for your persistence! It is indeed related to the font size. Reported at 8551

[rusty]

Please confirm whether this is fixed in the next build (1450). Thanks.

-Rusty