1256 SEVERE BUG Discrep in Clear Library behaviour[#5946]

[chrisjj]

1 Click File | Clear Library ...
2 Read "Are you sure you want to remove all data from the Library database (this will not delete any of your files)?"
3 Complete operation

Expected: Library cleared
Observed: Library, playlists, device profiles (and more??) cleared!

Workaround:
* for behaviour - none known, short of DB file hacking.
* for presentation - don't forget this command deletes important stuff outside the Library.

Suggested fix: adjust command and dialog wording to accord with behaviour.

EDIT Tracked at http://www.ventismedia.com/mantis/view.php?id=5946

[nohitter151]

I would think clear library would clear everything, thus it seems like expected behavior.

[chrisjj]

> I would think clear library would clear everything

I would think Clear Library would clear the library - not also things like playlists and device configs that are outside the library.

[Mizery_Made]

Change it to "Clear Database," and establish what all is saved (thus will be cleared) in the Database in the Help File. Problem solved.

[nohitter151]

I would think Clear Library would clear the library - not also things like playlists and device configs that are outside the library.

Where is it stipulated that playlists and device configs are not part of the library? I would expect all of them to be part of the library.

[nynaevelan]

I must be missing the point because my expectation is that Clear Library clears everything in the library including playlists, devices, filters etc... However it would be nice if there were two choices: 1 - clear library - which continues to clear everything and 2 - clear tracks - which clears all the tracks but maintains playlists, filters, devices etc...

But that aside I agree with NH, Clear Library should clear everything within the library and since playlists and devices are a part of the library I expect them to be cleared.

[Lowlander]

I'd expect it to clear everything as well. Especially playlists as they're connected to the tracks in the database. You can't clear the tracks from the database without resulting in empty manual playlists. Auto-Playlists might be problematic as well as they might use ID's, which change once you rescan tracks.

If you want to just clear the tracks go to the Artist node, select all tracks and remove them from the library.

That said, I see no problem with adding options (where feasible) on what to clear when using the Clear Library feature.

[nynaevelan]

Also, let me throw in another problem that could arise if you do not clear everything. I had a filter which was active that looked for wma tracks. Not realizing this filter was active, I cleared all the wma tracks from the library. The next time I tried to open MM, I kept getting AV errors because it could not find any of the tracks. I had to restore from a backup, change filters and then remove them again. What other problems could arise if everything is not cleared....

[Lowlander]

@nynaevelan
I'm not following, are you saying that MediaMonkey threw errors because you had no WMA tracks (ie no matching tracks for the active filter)?

If so it raises the following question:
- If a filter has no matching tracks no errors should occur, a warning might be useful though.

I wonder if a message when applying a filter that shows how many tracks are hidden (with option to hide such message) would be useful?

[nynaevelan]

@nynaevelan
I'm not following, are you saying that MediaMonkey threw errors because you had no WMA tracks (ie no matching tracks for the active filter)?

If so it raises the following question:
- If a filter has no matching tracks no errors should occur, a warning might be useful though.

I wonder if a message when applying a filter that shows how many tracks are hidden (with option to hide such message) would be useful?

LL:

Yes that is exactly what happened, and yes a warning would have been helpful because the AV message that I received wasn't exactly helpful either. I only figured out what the problem was because it gave the filter id, I opened the db in SQLite Spy and found which filter it was. It would have been nice that if no tracks/criteria existed in the db to meet the filter it would default to a non-filter. If you need me to reproduce the steps I could open my test db and re-do the steps.

[chrisjj]

>- If a filter has no matching tracks no errors should occur

Agreed 100%, LL!

But Nyn, your errors are not reproduced here (1256):

1 Create and engage a filter to show only FLAC
2 Delete any FLACs that show
3 Exit and relaunch

Expected: blank tracklist, no errors.
Observed: same!

> , a warning might be useful though.

Might be annoyng too.

[nynaevelan]

I tried to reproduce it but I cannot now, I do not know what it was doing then, maybe it was on a node or view from a script??

[chrisjj]

> maybe it was on a node or view from a script??

Mine was script-free.

Perhaps it was a script finding no tracsk that caused your AV. I guess a debug log would reveal.

[chrisjj]

> Where is it stipulated that playlists and device configs are not part of the library?

Right here:


> I would expect all of them to be part of the library.

I see nothing on UI or in Help to suggest they are.

[chrisjj]

> since playlists and devices are a part of the library I expect them to be cleared.

Playlists and devices are not part of the library and never have been, TMK.