1304 Removing track from library removes from NP [7008]

[chrisjj]

With (EDIT:) a track in Now Playing, and in the library, select it in under the Library node and delete it (from library only) - it disappears from NP.

EDIT(TC): Tracked at http://www.ventismedia.com/mantis/view.php?id=7008

[nynaevelan]

Shouldn't that be the expected behavior? If the track was added from the library and you delete it from the library I would expect it to delete it from NP and all references within the library.

[chrisjj]

If the track was added from the library

Thanks, but it wasn't. And it makes no difference.

[nynaevelan]

Thanks, but it wasn't. And it makes no difference.

Obviously it does, since that is how the developers programmed it to be....

[chrisjj]

Actually not. Try it and see.

[nynaevelan]

I guess this one is all about expectations, unless I am missing the point you are making, I expect it to remove it from the library, NP and any playlist references. Tell me why wouldn't you expect it to be removed from NP?? It is my understanding that tracks selected from the My Computer node can be in the NP list, but I would expect the behavior to be different for tracks which are added to NP that are actually in the library. Keep in mind I do not use or listen to tracks from the MC node so I am unfamiliar with it's expected behavior. I deal only with tracks in my library and I expect them to be removed from NP if I remove them from my library.

[chrisjj]

> Tell me why wouldn't you expect it to be removed from NP??

Because no-one asked for it to be removed from NP.

> Keep in mind I do not use or listen to tracks from the MC node so I am unfamiliar with it's expected behavior.

Ah, there's the difference between us. I often use NP for playing tracks from MC and Explorer. And for collecting a list to be exported to M3U. I don't want this messed up just because cleared library junk just happened to include one of those tracks.

[nynaevelan]

> Tell me why wouldn't you expect it to be removed from NP??

Because no-one asked for it to be removed from NP.

How much stuff does MM do that I did not ask it to do? But all that aside, if that is how the developers programmed it to be, then that is how it is, whether we want it that way or not. Since that is the behavior it is exhibiting I am going to go out on a limb and assume that is the way it is supposed to behave. I assume that MM is programmed to have different behavior with the removal of tracks from the library and those that are in NP that are not in the library.

Sorry to clog up your post with my expectations.

[chrisjj]

> Since that is the behavior it is exhibiting I am going to go out on a limb and assume that is the way it is supposed to behave.

Since the behaviour MM exhibits has changed in reponse to over a hundred reports of mine, I'm going to go out on a limb and suggest we wait and see

> Sorry to clog up your post with my expectations.

You're welcome!

[Lowlander]

I think it's done for clarity. It would probably confuse some if the tracks remained in the Now Playing. Although I have no issue with the track remaining in the Now Playing I think it's more clear if it's removed from the Now Playing when removing from the Library.

[chrisjj]

> I think it's done for clarity. It would probably confuse some if the tracks remained in the Now Playing.

I wonder where that logic stops. "For clarity" should the track be removed also from the player? From your HD?? From the web store you bought it from???

[Mizery_Made]

No, someone removing a song from their library should instantly incinerate every reference to the recording that has ever existed, duh. Though on this one, I'm going to have to agree with Chris. If you choose to delete it from the library, I see no reason for it also being removed from the NP list. As the NP list may contain references to Library tracks as well as tracks not contained within the library. Now if the individual selects to delete it from the Library & Computer, then I think there is some logic for also removing it from the NP list (and player).

This may come down to how the NP list references tracks however. If it's added through the MC node (or externally), then it's probably referenced via the file path and name. Whereas if it's a library track, I would guess it references those through the ID. Thus, if you delete it from the library, that ID no longer exists to reference. If that is the case, there may be performance benefits from using the ID and I would think this behavior would be an acceptable trade off.

[chrisjj]

> If it's added through the MC node (or externally), then it's probably referenced via the file path ...

Cewrtainly it seems that was true until 1131 - see http://www.mediamonkey.com/forum/viewto ... 24#p126024 .

> Whereas if it's a library track, I would guess it references those through the ID.

I can see no good reason for such an inconsistency.

> Thus, if you delete it from the library, that ID no longer exists to reference.

Since the ID is not required to reference it, the code could simply switch that reference to a filepath.

> If that is the case, there may be performance benefits from using the ID

I would have though the main performance effect would be detriment, since using the ID adds an indirection through the DB.

[nynaevelan]

Good, bad, logical or illogical, my personal opinion is if I remove it from the library than I want it removed from NP and everything else within my library. And if I choose the remove from Library and Computer option, then I want it removed from the library, NP and the computer. Just my opinion but I prefer the behavior it is using now. And as stated earlier, I only use the in Library option, not the MC option, so this is the only area I am speaking on.

[chrisjj]

> if I remove it from the library than I want it removed from NP and everything else within my library.

"Else"? NP is not in the library, note. If it was, I agree removal from it would be appropriate. But it is not, so it is not.