1459: Artwork change doesn't trigger sync update

[markstuartwalker]

If you change the artwork on a track that's in an auto-sync list for a device the file is not triggered to re-sync.

The artwork updates, the timestamp on the file updates but when I re-sync the file doesn't get added to the list of files to be synchronised.

I have only tested this with my d_itunes4 plugin but I know that this part of the function is a standard feature for all device plugins.

This did work on MM3.2.4.1304. HOWEVER that too seems to have a different bug where if the artwork is changed and "Apply to all album tracks" is on then ALL of the tracks trigger re-sync.

[tommycrock]

Hmm, I thought it also didn't work in MM3.2.4 (or .5 I can't remember) > http://mediamonkey.com/forum/viewtopic.php?f=12&t=58179
Volume analysis also doesn't seem to enable a resync, which is similarly annoying. I would hope (and would have guessed it would be easiest to program that) any change to the timestamp resulted in a resync. However, MM seems to (usually) be capable of matching tracks on the device that weren't initially synced by it but are on the sync list, so I guess it depends how they do the matching - which might take much longer if album art was read and compared.

[nohitter151]

According to this note, the whole file should not be recopied on tag updates:
http://www.ventismedia.com/mantis/view. ... 476#c23469

Fixed in build 1351.

To clarify how it exactly works:

1. If a track was tagged since the last auto-sync:
1a. For MSC devices, the tags are also updated on the device. Note that even in this case, the whole track is neither reuploaded nor auto-converted again, only tags are changed.
1b. For non-MSC devices, the device is only silently notified about the change (i.e. internal DB is updated, there's no info about it in the progress bar).

2. If a track was modified since the last auto-sync, but not tagged (e.g. played, which increased playcount):
2a. For all devices, the device is only notified about the change (so that e.g. iPod can update its playlists based on playcount).

[tommycrock]

Good point NoHitter, hadn't thought about play counts - and it's great that it does only change the tag rather than re-copying/transcoding. I think I'm probably wrong about volume analysis anyway
I also tested changing artwork - I deleted artwork for an album then added it in again - it did re-sync. That was on MSC with the WMDM DLL.

[markstuartwalker]

When artwork is changed and you have a converted (lower bitrate) file in the iDevice there is no way that a re-convert is triggered. Jiri's note confirms this.

To compensate I have specific code which checks tag values to see if any of them need to be pushed into iTunes. Alongside there is similar code to synchronise the images. Unfortunately this cannot use the 'remove images > xxxk' facility as it has no access to the flag and so the images are synchronised irrespectively - I have a user who reported this. My solution would be to simply remove the image sync code so whatever is in the converted file goes straight into iTunes. BUT it would never update if the image in the MM DB changed - hence my bug report.

p.s. I also have a reported but unresolved intermittent fault which occasionally causes many (1000's) tracks to be re-sync. It's real and I've suffered it myself but only on my fast 2 CPU PC under uncontrolled conditions. Might this be related?

The code releated to updating the playcounts is as follows. Do I need to add something to this?

Code: Select all

    // do we need to writeback the TSS entry?
  if data.updateDB then
  begin
    timeStamp:=MMdateToFloatStr(Now) ;
    sql:='update DEVICETRACKS set ' +
      ' DEVICEPATH=' + QuotedStr(data.DeviceTrackPath) +
      ',PLAYCOUNT=' + inttostr(data.PlayCount) +
//      ',SKIPCOUNT=' + inttostr(data.SkipCount) +
      ',RATING=' + inttostr(data.Rating) +
      ',UPLOADTIME=' + timestamp +
      ' where IDTRACK='+inttostr(data.trackID)+' and IDDEVICE='+inttostr(DeviceID);;
    log.text(2,i,sql);
    MMInterf.Database.ExecSQL(sql);
    data.updateDB:=false;
    Inc(stat.sqlTss);
  end;

[markstuartwalker]

This needs to be moved from the Beta forum

[markstuartwalker]

My original point still stands with my d_itunes plugin. A change in artwork does not cause a re-sync.

Jiri's note reports this fixed for MSC and non-MSC devices. I'm unclear what he means by "silently notified about the change". Are there new event types that have been added that I need to respond to?

Code: Select all

  // Notification type for DEVICE_NotifyFile()
  dnfDelete          = $01;  // Notifies that a file was deleted from the device
  dnfModified        = $02;  // Notifies that a file was uploaded to the device
  dnfConverted       = $04;  // Notifies that the file was also converted before uploading to device
  dnfTagsModified    = $08;  // Notifies that a file wasn't uploaded, but its tags were modified in PC and should be reflected in device
  dnfIsPodcast       = $10;  // Notifies that a file is an podcast episode
  dnfIsAudiobook     = $20;  // Notifies that a file is an audiobook track
  dnfRemovePlaylist  = $40;  // Notifies that this playlist should be removed from device

[nohitter151]

I had assumed that it meant the new art is copied to the device only, so the whole file does not need to be re-sent. Or for MSC devices, the tag was updated only (so the whole file did not need to be re copied).

[markstuartwalker]

How can I recognise "new art"? For textual tag entries I do a different and update the changed entries. For artwork there is no way of spotting that it's changed - there is no date or checksum to compare.

Further, if I blindly took the latest artwork and copied it over I still don't have access to the thresholds that control "Remove artwork > 300k" things.

[markstuartwalker]

I can confirm that I never receive the dnfTagsModified in the DEVICE_NotifyFile function except after a new file is added

New file sequence

Code: Select all

[2184] d_itunes4.dll 2122 14:27:55 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 8
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   8=0
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ListPlaylists start
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ListContent start
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ListPlaylists end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 10
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   10=-1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 11
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   11=-1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 17
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   17=-1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ModifyFilenames start 10
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ModifyFilenames end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetString start 5
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetString end 
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_ListContent end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_AvailBytes start
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_AvailBytes end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_DeleteFiles start 1
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_DeleteFiles end
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:27:55 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:27:57 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:27:57 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:28:10 DEVICE_UploadTrack start h:\temp\3F9E_09 My Legs Are Weak.mp3DEFC
[2184] d_itunes4.dll 2122 14:28:10 DEVICE_UploadTrack end
[2184] d_itunes4.dll 2122 14:28:10 DEVICE_NotifyFile start \9876.mp3 6
[2184] d_itunes4.dll 2122 14:28:10 DEVICE_NotifyFile end
[2184] d_itunes4.dll 2122 14:28:10 DEVICE_NotifyPlaylist start TenTracks 10
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_NotifyPlaylist end
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag start 9
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag end   9=0
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:28:11 DEVICE_GetFlag end   1=0

Changed the title ID3tag

Code: Select all

[2184] d_itunes4.dll 2122 14:29:44 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 8
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   8=0
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_ListPlaylists start
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_ListContent start
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_ListPlaylists end
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 10
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   10=-1
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag start 11
[2184] d_itunes4.dll 2122 14:29:44 DEVICE_GetFlag end   11=-1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 17
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   17=-1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_ModifyFilenames start 10
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_ModifyFilenames end
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetString start 5
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetString end 
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_ListContent end
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_AvailBytes start
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_AvailBytes end
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_DeleteFiles start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_DeleteFiles end
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_NotifyPlaylist start TenTracks 10
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_NotifyPlaylist end
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 9
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   9=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:29:45 DEVICE_GetFlag start 1

Changed the album art

Code: Select all

[2184] d_itunes4.dll 2122 14:33:06 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_SetValue start
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_SetValue end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 8
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   8=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ListPlaylists start
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ListContent start
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ListPlaylists end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 10
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   10=-1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 11
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   11=-1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 17
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   17=-1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ModifyFilenames start 10
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ModifyFilenames end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetString start 5
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetString end 
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_ListContent end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_AvailBytes start
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_AvailBytes end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 3
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   3=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_DeleteFiles start 1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_DeleteFiles end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_NotifyPlaylist start TenTracks 10
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_NotifyPlaylist end
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 4
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   4=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 9
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   9=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 1
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag end   1=0
[2184] d_itunes4.dll 2122 14:33:06 DEVICE_GetFlag start 1

[markstuartwalker]

Good point NoHitter, hadn't thought about play counts - and it's great that it does only change the tag rather than re-copying/transcoding. I think I'm probably wrong about volume analysis anyway
I also tested changing artwork - I deleted artwork for an album then added it in again - it did re-sync. That was on MSC with the WMDM DLL.

Can you clarify what "it did re-sync" means? Did it re-copy the file or somehow extract the artwork and transfer just that?

On my instance of USBMass1 the file got re-copied. That isn't ideal behaviour.

[markstuartwalker]

I've just got back to this one

My original point still stands with my d_itunes plugin. A change in artwork does not cause a re-sync.

Jiri's note reports this fixed for MSC and non-MSC devices. I'm unclear what he means by "silently notified about the change". Are there new event types that have been added that I need to respond to?

My plugin does not receive a dnfTagsModified parameter in DEVICE_NotifyFile. Consequently there is no way of triggering a re-sync when artwork changes.

I have re-check this today with build 1463 and this is still true.

Scenario is
* Create a track with a single artwork image
* sync to iTunes via a single-track playlist
* confirm in iTunes that the correct artwork is seen
* use MM to add a second artwork to the track
* re-sync to iTunes
* confirm in iTunes that unchanged artwork is still present i.e. the track has not been updated.

By running DebugView in background and debug=3 and filter="DEVICE_NotifyFile" you can see that this is never called with '8' as a passed parameter.

[Ludek]

Hi Mark, I cannot reproduce the issue.
I downloaded your plugin from here: http://www.mediamonkey.com/addons/brows ... or-itunes/
and after adding/removing artwork I see:

[1980] d_itunes4.dll 2216 23:05:25 DEVICE_NotifyFile start \6948.mp3 8
[1980] d_itunes4.dll 2216 23:05:25 DeviceiTunesNotifyFile start
[1980] d_itunes4.dll 2216 23:05:25 TagsModified \6948.mp3
[1980] d_itunes4.dll 2216 23:05:25 syncSetTrackRatingAndPlayed 0
[1980] d_itunes4.dll 2216 23:05:25 difference found #11 0 -1
[1980] d_itunes4.dll 2216 23:05:25 syncSetTrackRatingAndPlayed 0
[1980] d_itunes4.dll 2216 23:05:25 DeviceiTunesNotifyFile end

despite the fact whether I added the artwork to tag or just to file folder (Tested build 4.0.2.1462)

[markstuartwalker]

Yes, that is the point. There is no NofifyFile call with just the changed code. Try debug=3

[Ludek]

Mark, in my case there IS the NofifyFile call as can be seen from the debug lines above. It was with debug=3. So I don't know what can be the difference.