[Delete This]

Eyal · Post by **Eyal** » Tue Jul 17, 2007 4:21 pm

Hi some1

I was too impatient to have it work with multi-CD albums having track# 101,102,...,201,202,...

So I found a way to make it work. Except these albums are still listed in the FindTheMissing node but do not generate any report. That's because the code is based on the last track# to determine the lenght of the array.

Replace the FindTheMissing sub with this one:

Code: Select all

(code deleted)

What do you think?

some1 · Post by **some1** » Tue Jul 17, 2007 5:28 pm

Thanks Eyal! It was on my ToDo list, but you have crossed it off for me!

*Sorry I wasn't quick enought for you, and your had to do it.*

I see what your done

and yep, I like it!
Two things, and this is without me trying it out, ive only looked at it (and its pass 1am where i am!)

1.) If there isn't track 101, then would it fail? due to there not beening track 1,2 or 101

Code: Select all

 If i=0 Then                              'It's the first track of the album

2.) What happens when CD1 ends (say at 125), and CD2 starts (at 201), would it list track 126-200?

Im adding in two new feautres ( [FindThe] ExtraTracks & [FindThe] SmallAlbums (listed here first!) ), so I will be inculding your mods into it all! and thanks for doing/making them

--Some1

Eyal · Post by **Eyal** » Tue Jul 17, 2007 8:51 pm

Yes it will work exactly as it should.
If there's no track# below 100 it will start comparing at 101.

It's working with an album containing
101, 102, 103, ..., 201, 202, 203, ..., 301, etc...

But as I said, I dont' know how to prevent such albums to be listed in the node if there's no missing track.

Eyal

some1 · Post by **some1** » Wed Jul 18, 2007 2:48 am

Yes it will work exactly as it should.
If there's no track# below 100 it will start comparing at 101.

It's working with an album containing
101, 102, 103, ..., 201, 202, 203, ..., 301, etc...

I meant, if there isn't track 101, will it work?
Edit: Ive just tired it, it works well, but if track 101 isn't there, it report its, along with all the other missing track, but it also says that track 1 is missing.
Also it didnt pick up my second CD at track 201.

But as I said, I dont' know how to prevent such albums to be listed in the node if there's no missing track.

Sorry, do you mean, dont show the tracks which are there, but show the missing ones?

edit:
I have added this to v0.4, and posted what ive done so far, to my first post.
Could I check that ive added it in right...

Dim list, itm, i,j,k, trackno, last, MissingSongs, offset

offset=0 '<<< Offset for multi-CD albums (100, 200, 300, ...)

'[Thank you Eyal] Calculate offset for tracks begining with > 100: <<<< Untested
If i=0 Then 'It's the first track of the album
If trackno = j + 100 Then 'Check if track# begins at 101
offset = offset + 100 'Adjust offset
j = j + 100
i = i + 100
End If
'Calculate offset for tracks begining with > 100:
ElseIf trackno > offset + 100 Then 'Track# changes range
offset = offset + 100 'Adjust offset
j = offset + 1
i = offset
End If

Is there anything else?

Eyal · Post by **Eyal** » Wed Jul 18, 2007 10:49 am

OK to clarify everything, here are the tests I did:

Existing tracks in one album = Missing tracks report.
1-12, 102-111 = 101
2-11, 103-111, 203,205 = 1, 101,102, 201,202,204
101,103,104,106-111, 202,205, 301-307, 504,505, 903 = 102,105,201,203,204,401,501-503,601,701,801,901,902

100 = 1-99
200 = 1, 101-199
500 = 1, 101, 201, 301, 401-499

I think it's pretty satisfying.

Now, in the FindTheMissing node, are listed all albums containing missing track(s). If it's a multi-CD album (with tracks 101,102,...,201,202,...) it will be listed in the node even if it don't contains missing tracks. That's the point.

some1 · Post by **some1** » Thu Jul 19, 2007 4:15 am

OK to clarify everything, here are the tests I did:
Existing tracks in one album = Missing tracks report.
1-12, 102-111 = 101
2-11, 103-111, 203,205 = 1, 101,102, 201,202,204
101,103,104,106-111, 202,205, 301-307, 504,505, 903 = 102,105,201,203,204,401,501-503,601,701,801,901,902

100 = 1-99
200 = 1, 101-199
500 = 1, 101, 201, 301, 401-499
I think it's pretty satisfying.

Yep! That is! BIG THANKS!

ve added it into v0.4, and Im just about to post it!

Now, in the FindTheMissing node, are listed all albums containing missing track(s). If it's a multi-CD album (with tracks 101,102,...,201,202,...) it will be listed in the node even if it don't contains missing tracks. That's the point.

This is because it uses a another method of getting the code (I lifed that from "TaggingInconsistencies v2.2 by Bex")!

some1 · Post by **some1** » Thu Jul 19, 2007 4:46 am

v0.4 (19/07/07)
* Renamed [FindTheMissing] Songs to "[FindThe]" because of the (new) functions "Missing Tracks", "Extra Tracks" and "Small Albums"
* Applied Eyal offset mod for multiple CD

Eyal · Post by **Eyal** » Thu Jul 19, 2007 2:10 pm

Hi some1

Replace line 534 of FindThe.vbs (v 0.4) to:

Code: Select all

If trackno >= j + 100 Then    'Check if track# begins at greater than 100

instead of

Code: Select all

If trackno = j + 100 Then

and it will no longer report track# 1 as missing in multi-CD albums.

I should have thought of it before.

Eyal

some1 · Post by **some1** » Fri Jul 20, 2007 9:40 am

Edited v0.4

Diabolic-Destiny · Post by **Diabolic-Destiny** » Fri Jul 20, 2007 4:31 pm

thanks for the PM, i've placed it in my /scripts/auto folder and named it as FindThe.vbs Under tools>script>FindTheMissing and i get this error

"You have no such artists In your visible Library"

am i doing something wrong?

some1 · Post by **some1** » Thu Aug 09, 2007 4:46 pm

haven't got a clue!
Sorry!
Will have a look

---------------------------------------------------
edit:
Diabolic-Destiny - Please could you tired v0.4.1
and could you say what happens when you try what?

Thanks

some1 · Post by **some1** » Sun Aug 12, 2007 11:51 am

Updated
v0.4.1 (12/08/07)
* Fix bug in offset mod
* Tweaked SQL querry - Remove dup lines + extra code
* Added msgbox with Same track no, Untagged trags as well as missing track (the report)
* New sorting method of calcuting track stats/Facts.
* Bit of extra commenting on key parts of this!

--Some1

Diabolic-Destiny · Post by **Diabolic-Destiny** » Mon Aug 13, 2007 12:00 pm

working great now thanks

Id like to add i have a double album

and so iv made the track list

starting at 101-122 for CD1 (or track 1-22)
and CD2 201-217 (Track 1-17)

yet it shows i have 39 tracks out of 217

Is there a way this can be overwritten..?

some1 · Post by **some1** » Tue Aug 14, 2007 12:09 pm

Hey!
This is in the known bug bit!
I'm working on it!

Diabolic-Destinyy · Post by **Diabolic-Destinyy** » Thu Aug 16, 2007 6:44 pm

umm im gettin a messed up random error now

Error #-214718113 -
File: "C:\Program Files\Mediamonkey\Scripts\Auto\FindThe.vbs", Line: 173,Column: 3

it just started outta no where any ideas? I've tried reinstalling with no luck..

[Delete This]

FindTheMissing sub that works with track# 101, 201, 301...