That fixed my problem! Thanks for the quick fix.

-- Gregg

New version (3.2) is now available to download from my website. I've fixed disc numbers larger than 9, again.

I think I've already fixed this issue in the next version, I just haven't got round to releasing it yet. I'll try and get it out later today.

trixmoto - Thanks for writing and sharing great scripts!

I installed Combine Albums 3.1 today and I received an error message every time I try to use the script.

[quote]Error #5 - Microsoft VBScript runtime error
Invalid procedure call or argument: 'Left'
File: "C:\Program Files (x86)\MediaMonkey\Scripts\CombineAlbums.vbs", Line: 142, Column: 4[/quote]

I've been trying to use mode 5 (Disc=1 and Track=1##) of the script. I'm using MediaMonkey version 4.0.7.1511 on a Windows 7 computer. I've tried installing Combine Albums as an Administrator and I've tried using the script as an Administrator, and I get the error regardless.

Any assistance you can provide would be appreciated!

Thanks,

Gregg

Great, thanks.

You're right- seems I've mixed up things, 3.1 is working fine ;)
I'll post an update to the regex soon as I'm seeing more naming conventions that could be handled, so stay tuned.

Can you be more specific about the errors you're getting? I've tried and I'm not getting any errors. And the code you've posted is identical to mine, except you use "CInt" instead of "Int" (which do the same thing, effectively) and you've only got the numeric half of the "if" statements.

Ok, I'll take another look.

' 1. AlbumName (CD 1) -> AlbumName and Track=1##

Sub process1(itm, albumname, disc)
'	msgbox("proc1 "&albumname&" "&disc)
  disc = CInt(disc) * 100

  Do While itm.TrackOrder > 100
    itm.TrackOrder = itm.TrackOrder - 100
  Loop

  itm.AlbumName = albumname
  itm.TrackOrder = disc + itm.TrackOrder
End Sub


' 2. AlbumName (CD 1) -> AlbumName and Disc=1

Sub process2(itm, albumname, disc)
'	msgbox("proc2 "&albumname&" "&disc)
  disc = CInt(Left(disc,Len(disc)-2))

  itm.AlbumName = albumname
  itm.DiscNumber = disc
End Sub


' 3. Track=1## -> Disc=1 and Track=##

Sub process3(itm,c)
  Dim s : s = itm.TrackOrderStr
  If Len(s) > 2 Then
    c = c + 1
    itm.DiscNumber = Int(Left(s,Len(s)-2))
    itm.TrackOrder = Int(Mid(s,2))
  End If
End Sub

Hi Trixmoto,

unfortunately you're updated 3.1 doesn't seem to contain the necessary changes and gives me errors. Only did a quick check but process1..3 need to look like this:

[code]
' 1. AlbumName (CD 1) -> AlbumName and Track=1##

Sub process1(itm, albumname, disc)
' msgbox("proc1 "&albumname&" "&disc)
disc = CInt(disc) * 100

Do While itm.TrackOrder > 100
itm.TrackOrder = itm.TrackOrder - 100
Loop

itm.AlbumName = albumname
itm.TrackOrder = disc + itm.TrackOrder
End Sub


' 2. AlbumName (CD 1) -> AlbumName and Disc=1

Sub process2(itm, albumname, disc)
' msgbox("proc2 "&albumname&" "&disc)
disc = CInt(Left(disc,Len(disc)-2))

itm.AlbumName = albumname
itm.DiscNumber = disc
End Sub


' 3. Track=1## -> Disc=1 and Track=##

Sub process3(itm,c)
Dim s : s = itm.TrackOrderStr
If Len(s) > 2 Then
c = c + 1
itm.DiscNumber = Int(Left(s,Len(s)-2))
itm.TrackOrder = Int(Mid(s,2))
End If
End Sub
[/code]

Will check asap- thank you!

New version (3.1) is now available to download from my website. I have fixed disc numbers larger than 9, thanks to [b]andig[/b].

Ok, cheers.

[quote="trixmoto"]Ok, I'll see if I can combine the two :) Also, you've changed the regular expressions, but these aren't really my strong suit - do you remember what you changed and why?[/quote]

Honestly they didn't match my local version and I had no clue where those changes came from (looked like artifacts). Feel free to change them back but please check if the matching brackets where moved and different array indexes of the matches are used further on.

Ok, I'll see if I can combine the two :) Also, you've changed the regular expressions, but these aren't really my strong suit - do you remember what you changed and why?

No- I probably didn't recognize this.

Kind regards,
Andreas