[2822] MM Analyze Volume, scans more than selected amount

Post a reply

Smilies
:D :) :( :o :-? 8) :lol: :x :P :oops: :cry: :evil: :roll: :wink:

BBCode is ON
[img] is ON
[url] is ON
Smilies are ON

Topic review
   

Expand view Topic review: [2822] MM Analyze Volume, scans more than selected amount

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Mon Nov 13, 2023 4:20 am

AFAIK most apps that i have used which use volume analysis, do by default only tracks analysis. Track analysis is useful as it makes all tracks the same volume. I do not know how they handle album volume is it blank and only calculated when the whole album is selected. Foobar has the option to scan "selection" as an album or scan album by tags. I like that approach. For me it is convenient do the scanning in little batches, where i would select what i wanted scanned.

The original problem that started this all was Unanalyzed volume node. Why not have a trigger from there to scan tracks and complete albums? Instead of the other nodes.

Re: [2822] MM Analyze Volume, scans more than selected amount

by rusty » Wed Nov 08, 2023 4:32 pm

We could add a new dialog, but I prefer not to add extra steps unless it's really necessary/valuable for most users.

Since it seems that the current 5.0.4 behavior is well understood, maybe we should allow for that behavior unless the new option below is enabled. e.g.:

[x] Only analyze files with unknown Leveling Adjustment
[ ] Automatically analyze volume of unanalyzed files
[x] When analyzing Track volume, also analyze Album volume
. . [x] Analyze all tracks on the album

If the last option is disabled, then the question is what should happen in case the user selects a subset of the album. Possible options:
a) Generate an incorrect Album leveling value
b) Leave the Album leveling value empty
c) 5s Toast message e.g. 'Some of the selected files are subsets of an album. Include all tracks (for accuracy)? [[Yes]] [No]' (might not be possible in the short term).

Thoughts?

-Rusty

Re: [2822] MM Analyze Volume, scans more than selected amount

by Rob_S » Wed Nov 08, 2023 2:59 pm

Would it be too hard to have MM pop up a dialog if it intends to analyze anything more than the actual selection, allowing the user to opt out?

Settings choices could remain as is, the above would be a failsafe for occasions such as mentioned in the above post.

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Wed Nov 08, 2023 2:39 pm

Hi Rusty,

Ok i understand now, but all these years i liked how mm did the volume analysis of just selected tracks and if i wanted to analyze a whole album i would do it manually by selecting all those tracks. It is the same principle with most popular audio apps out there. I don't want to select 6000 tracks for volume analysis and to find out mm is going to scan 60000+ plus songs because of all the unanalyzed albums. How many hours/days will that take? I want to be in control of what files and how many files are analyzed.

Look at the options in foobar2000
Image

and this is musicbee
Image

Image

Re: [2822] MM Analyze Volume, scans more than selected amount

by rusty » Wed Nov 08, 2023 10:35 am

Hi robojock,

You're right that the behavior has changed and is confusing, but the old 5.0.4 behavior was also problematic.

To explain, the old behavior was buggy because if Album gain is set to be calculated for 1 of 10 tracks on an album, then all the tracks on the album must be analyzed in order to get a correct Album Gain value (or a null Album gain value).

Without looking into the code, it appears that the fix to that issue was implemented but without the associated UI! We're looking into the best solution. Details at:
https://www.ventismedia.com/mantis/view.php?id=17779

Thanks!

-Rusty

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 11:03 pm

Peke wrote: Tue Nov 07, 2023 4:54 pm
robojock wrote: Tue Nov 07, 2023 3:59 pm Not for random individual tracks as in my case located in playlist.
If track you select for Analyze have Album Info MM auto start analyze fo all tracks on album. Additionally if you enable Auto Analyze on unanalyzed tracks then MM starts analyze on all unanalyzed tracks.

Same goes for 5.0.4 and 5.1.
No I DO NOT agree with you. Since mm implemented volume analyzing in mm3 (maybe before that) if individual tracks tracks were selected it will ONLY do track analysis. If you select an album and analyze the songs then it will do tracks analysis + album. This is the Default behavior with most music apps that do volume analyzing. I am not going to install every single beta version from 5.0.4 to 5.1 just to prove a point. NEVER has mm analyzed additional songs when being selected in a playlist. Then i might as well just enable auto analyze and let mm be a resource hog while its running. It is a bug introduced in beta builds!

Volume analysis works correct in 5.0.4 as proven here
https://i.postimg.cc/brCCRXyb/Untitled-3.png
and with the same playlist volume analysis does not work here in 5.1
https://i.postimg.cc/GtZVvwh2/Untitled-2.png

Re: [2822] MM Analyze Volume, scans more than selected amount

by Peke » Tue Nov 07, 2023 4:54 pm

robojock wrote: Tue Nov 07, 2023 3:59 pm Not for random individual tracks as in my case located in playlist.
If track you select for Analyze have Album Info MM auto start analyze fo all tracks on album. Additionally if you enable Auto Analyze on unanalyzed tracks then MM starts analyze on all unanalyzed tracks.

Same goes for 5.0.4 and 5.1.

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 3:59 pm

Lowlander wrote: Tue Nov 07, 2023 3:52 pm As Peke mentioned this happens when you have When analyzing Track volume, also analyze Album volume enabled under Tools > Options > Volume leveling. Disable the option and this won't happen.
Both MM 5.0.4.2693 and 5.1.0.2822 have that setting enabled by default. It works correctly in 5.0.4.2693 and NOT in 5.1.0.2822. and FYI that setting is for when analyzing an album with all its tracks. Not for random individual tracks as in my case located in playlist.

Re: [2822] MM Analyze Volume, scans more than selected amount

by Lowlander » Tue Nov 07, 2023 3:52 pm

As Peke mentioned this happens when you have When analyzing Track volume, also analyze Album volume enabled under Tools > Options > Volume leveling. Disable the option and this won't happen.

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 3:49 pm

Lowlander wrote: Tue Nov 07, 2023 3:44 pm As mentioned, this is by design. All files on an Album will be analyzed when files on an Album are selected to be analyzed.
When did this "design" become active in mm? So if i have a playlist with 1000 songs and each song belongs to an album which contains 20 songs each mm will now decide to to scan all those albums too? Where i just wanted to scan only 1000 songs?

Re: [2822] MM Analyze Volume, scans more than selected amount

by Lowlander » Tue Nov 07, 2023 3:44 pm

As mentioned, this is by design. All files on an Album will be analyzed when files on an Album are selected to be analyzed, so that Album Volume can be calculated for the selected files.

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 3:38 pm

Lowlander wrote: Tue Nov 07, 2023 3:34 pm As mentioned, if you select 1 track for analysis, it will analyze all tracks on the Album. This is likely what's happening. All unselected files on selected Albums are also being analyzed. This is expected.
No it's NOT! MM 5.0.4.2693... 6263 selected to analyze. 6263 are being analyzed

Image

Re: [2822] MM Analyze Volume, scans more than selected amount

by Lowlander » Tue Nov 07, 2023 3:34 pm

As mentioned, if you select 1 track for analysis, it will analyze all tracks on the Album. This is likely what's happening. All unselected files on selected Albums are also being analyzed. This is expected.

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 3:31 pm

Peke wrote: Tue Nov 07, 2023 3:23 pm Hi,
I can't replicate it at any node if I disable all three options, which forces analyze no matter if tracks already had Volume index.
i can always replicate, if i select a few songs in artist node or album node, the mm on analyzes those songs selected

Re: [2822] MM Analyze Volume, scans more than selected amount

by robojock » Tue Nov 07, 2023 3:29 pm

Lowlander wrote: Tue Nov 07, 2023 3:21 pm Are you saying files not on the Albums included in the selection are being analyzed.

As mentioned a higher number of files being analyzed is expected.
Yes, another example, playlist has 6263 files selected, right click analyze tracks, bottom left now mm is saying there 64960 songs to be analyzed, i only selected 6263

Image

Top