auto tag crashing [#17330]

[ferd]

[EXTERNAL URL DROPBOX]/s/zit3d94uil9zy01/Afraid%20of%20Love.mp3?dl=0

The above mp3 crashes auto tag MM 5.0.0.2291 in both regular and safe mode.

A2804DF9 is the log reference.

[Ludek]

Hi,
I tried and couldn't replicate the crash with DropBox files.

The log A2804DF9 probably failed to submit as I don't see it here.

Could you please try to find the error report as MediaMonkeyEngine.el located in the same folder as MediaMonkey.exe or at c:\Users\<USERNAME>\AppData\Roaming\EurekaLab s.a.s\EurekaLog\Bug Reports\
?

Thanks!

[ferd]

Code: Select all

1.1 Start Date      : Mon, 4 Jan 2021 23:26:39 -0800
  1.2 Name/Description: MediaMonkeyEngine.exe - (MediaMonkey)
  1.3 Version Number  : 5.0.0.2291
  1.4 Parameters      : --type=renderer --no-sandbox --autoplay-policy=no-user-gesture-required --file-url-path-alias="/gen=C:\Program Files (x86)\MediaMonkey 5\gen" --js-flags="\"--expose-gc\"" --log-file="C:\Program Files (x86)\MediaMonkey 5\debug.log" --remote-debugging-port=9222 --field-trial-handle=2932,5693799804314550644,6747280146146181843,131072 --disable-features=IsolateOrigins,site-per-process --lang=en-US --locales-dir-path="chromium\79\locales\\" --log-file="C:\Program Files (x86)\MediaMonkey 5\debug.log" --log-severity=disable --uncaught-exception-stack-size=10 --device-scale-factor=1.25 --num-raster-threads=2 --enable-main-frame-before-activation --service-request-channel-token=7681865611744711961 --renderer-client-id=3 --mojo-platform-channel-handle=3020 /prefetch:1
  1.5 Compilation Date: Tue, 22 Dec 2020 13:45:20 -0800
  1.6 Up Time         : 10 hour(s), 11 minute(s), 13 second(s)

Exception:
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  2.1 Date          : Tue, 5 Jan 2021 09:37:53 -0800
  2.2 Address       : 017CB0B5
  2.3 Module Name   : MediaMonkeyEngine.exe - (MediaMonkey)
  2.4 Module Version: 5.0.0.2291
  2.5 Type          : EJSException
  2.6 Message       : "release is not defined"
                      .
 
Steps to reproduce:
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  8.1 Text: Uncaught Error:_"release is not defined"
            .
            ReferenceError:_release is not defined
                at eval (file:///helpers/searchCommon.js:506:118)
                at Array.some (<anonymous>)
                at eval (file:///helpers/searchCommon.js:495:58)
                at Promise.eval (file:///helpers/searchCommon.js:327:32)
                at invokeResolver (file:///promise.js:387:18)
                at new Promise (file:///promise.js:374:7)
                at finished (file:///helpers/searchCommon.js:320:28)
                at eval (file:///helpers/searchCommon.js:618:49)
                at invokeCallback (file:///promise.js:399:19)
                at publish (file:///promise.js:457:9)
             at line 506!!
            .
            Source code:
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------            502.                                                         }
            503. 
            504.                                                         if ((look.number === undefined) || (look.number === null)) {
            505.                                                             if ((!look.release) && (_this._processTrackReleaseGroup)) {
            506.                                                                 ar.push(_this._processTrackReleaseGroup(track, look, release[top], look.recording));
            507.                                                             }
            508.                                                             
            509.                                                             if (_this._processTrackRelease) {
            510.                                                                 ar.push(_this._processTrackRelease(track, look, look.release/*release[top]*/, look.recording));
            511.                                                             }
            .
            .
            .
            Script:_file:///mminit.js
            .
            Line 284:_                _alert(str, window['__lastScriptName']);
            .
            .
            Callstack:
---------------------------------------------------------            .
            file:///mminit.js :_window.myAlert(284)
            .
            file:///mminit.js :_window.alertException(294)
            .
            file:///mminit.js :_window.onerror(264)

.
.

[Ludek]

Thx, fixed as https://www.ventismedia.com/mantis/view.php?id=17330

[feerd]

I couldn't access the fix to see if it works. I made this change to 2291:

(file:///helpers/searchCommon.js:506:118)

ar.push(_this._processTrackReleaseGroup(track, look, look.release/*release[top]*/, look.recording));

can you confirm?

[Lowlander]

It hasn't been released yet. Current available is 2291, the fix is in 2292, which still has to be released.

[Ludek]

The fix will be in 2292 (to be posted this week)

I couldn't access the fix to see if it works. I made this change to 2291:

(file:///helpers/searchCommon.js:506:118)

ar.push(_this._processTrackReleaseGroup(track, look, look.release/*release[top]*/, look.recording));

can you confirm?

Along with this change: https://www.dropbox.com/s/297evw3z3p0tw ... 2.png?dl=0

[ferd]

CORRECTION: I misread the typo above:

"It hasn't been released yet. Current available is 2291, the fix is in 2292, which still has to be released"

I thought this meant that 2291 was a rolling update. I've added the patch myself and will retest.

[Ludek]

There is already 2293 RC2 including the fix. So no need for a patch anymore.