1255 View | (Track) Properties enabled on Tree node [6855]

Beta Testing for Windows Products and plugins

Moderator: Gurus

chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

1255 View | (Track) Properties enabled on Tree node [6855]

Post by chrisjj »

...whereas surely it should not be.

Note: Toolbar Edit Properties is disabled as expected.


EDIT(TC) Tracked at http://www.ventismedia.com/mantis/view.php?id=6855
Chris
nohitter151
Posts: 23640
Joined: Wed Aug 09, 2006 10:20 am
Location: NJ, USA
Contact:

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by nohitter151 »

chrisjj wrote:...whereas surely it should not be.
Why not? A track is already selected in main panel, so why should it be disabled?
MediaMonkey user since 2006
Need help? Got a suggestion? Can't find something?

Please no PMs in reply to a post. Just reply in the thread.
ZvezdanD
Posts: 3265
Joined: Thu Jun 08, 2006 7:40 pm

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by ZvezdanD »

It is not selected, even if it looks like that: Some options disabled, although tracks are selected [#5441]
Magic Nodes 4.3.3 / 5.2 RegExp Find & Replace 4.4.9 / 5.2  Invert Selection/Select None 1.5.1  Export/Create Playlists for Child Nodes 4.1.1 / 5.4.1  Expand Child Nodes/Expand All 1.1.2  Event Logger 2.7  Filtered Statistics Report 1.6  Track Redirection & Synchronization 3.4.2  Restore/Synchronize Database 3.1.8 / 4.0.1  Find Currently Playing Track 1.3.2  Queue List 1.2.1  Add to Library on Play 1.0.1  Tree Report for Child Nodes 1.1.1  Update Location of Files in Database 1.4.5 / 2.3  Inherit Child Playlists 1.0.3  Add Currently Playing/Selected Track(s) to Playlist 1.2
nohitter151
Posts: 23640
Joined: Wed Aug 09, 2006 10:20 am
Location: NJ, USA
Contact:

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by nohitter151 »

ZvezdanD wrote:It is not selected, even if it looks like that: Some options disabled, although tracks are selected [#5441]
Well, I guess technically it isn't selected. But it is still highlighted and the track properties still shows that highlighted track. I don't see any reason to disable it.
MediaMonkey user since 2006
Need help? Got a suggestion? Can't find something?

Please no PMs in reply to a post. Just reply in the thread.
ZvezdanD
Posts: 3265
Joined: Thu Jun 08, 2006 7:40 pm

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by ZvezdanD »

nohitter151 wrote:Well, I guess technically it isn't selected. But it is still highlighted and the track properties still shows that highlighted track. I don't see any reason to disable it.
Why enabled state of View / Properties should be different than Edit / Properties and many other options from the Tools menu? Did you see a very good and detailed explanation which rusty had in mantis related to my report about this strange behavior?
Magic Nodes 4.3.3 / 5.2 RegExp Find & Replace 4.4.9 / 5.2  Invert Selection/Select None 1.5.1  Export/Create Playlists for Child Nodes 4.1.1 / 5.4.1  Expand Child Nodes/Expand All 1.1.2  Event Logger 2.7  Filtered Statistics Report 1.6  Track Redirection & Synchronization 3.4.2  Restore/Synchronize Database 3.1.8 / 4.0.1  Find Currently Playing Track 1.3.2  Queue List 1.2.1  Add to Library on Play 1.0.1  Tree Report for Child Nodes 1.1.1  Update Location of Files in Database 1.4.5 / 2.3  Inherit Child Playlists 1.0.3  Add Currently Playing/Selected Track(s) to Playlist 1.2
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by chrisjj »

> A track is already selected in main panel, so why should it be disabled?

A track is selected in the Track List, but we are using (i.e. the focus is in) the Tree pane, not the Track List pane.

(Track) Properties should be disabled because there is no track selected in the pane we are using.
Chris
nohitter151
Posts: 23640
Joined: Wed Aug 09, 2006 10:20 am
Location: NJ, USA
Contact:

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by nohitter151 »

chrisjj wrote: (Track) Properties should be disabled because there is no track selected in the pane we are using.
Look, I see your point as well as ZvezdanD's. But the fact remains that a track is still highlighted (yes, technically not selected, but it is differentiated from other tracks by some color), so why should it be disabled? What advantage does disabling it have?
MediaMonkey user since 2006
Need help? Got a suggestion? Can't find something?

Please no PMs in reply to a post. Just reply in the thread.
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1255 View | (Track) Properties enabled on Tree node -------

Post by chrisjj »

> a track is still highlighted (yes, technically not selected, but it is differentiated from other tracks by some color), so why should it be disabled?

The command should be disabled because it is inapplicable to the focussed selected object.

> What advantage does disabling it have?

Disabling the command has the advantage of showing the user it is inapplicable to the focussed selected object.

For an app to find some out of focus object that the command could apply it to, and on that basis enable the command, is a recipe for total confusion. The whole point of focus is to direct commands to objects. Without this, a user could never see in advance what object a command would apply to, and could find out only by incurring an unknown risk of experiment. A risk that is substantially greater, note on an app that has no Undo.
Chris
Lowlander
Posts: 58631
Joined: Sat Sep 06, 2003 5:53 pm

Re: 1255 View | (Track) Properties enabled on Tree node [685

Post by Lowlander »

To be clear, do you mean that Properties is available when you right click in an empty area in the Explorer Tree (not a node) or do you mean right click on an actual node. The latter I don't see on 1304. With the former I agree, but only happens when no node has focus, when a node does have focus and you right click in empty space it will show right context menu for Explorer Tree.
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1255 View | (Track) Properties enabled on Tree node [685

Post by chrisjj »

> To be clear, do you mean that Properties is available when you right click
> in an empty area in the Explorer Tree (not a node) or do you mean right click on an actual node.

Neither. "View" is on the menu bar.

> With the former I agree, but only happens when no node has focus, when a node does have focus
> and you right click in empty space it will show right context menu for Explorer Tree.

Separate issue.
Chris
Lowlander
Posts: 58631
Joined: Sat Sep 06, 2003 5:53 pm

Re: 1255 View | (Track) Properties enabled on Tree node [685

Post by Lowlander »

Okay, I see. I see no issue that Properties is enabled when a track(s) is highlighted in the Tracklisting when the Explorer Tree has focus. I actually think that it's useful as you don't need to focus back to the Tracklisting to get to the Properties of the highlighted track(s) thus reducing the amount of steps (especially for those who use keyboards more than mouse). I don't think there is a confusion that Properties doesn't apply to tracks.
Properties is properly disabled when no track is highlighted so I see no issue.
chrisjj
Posts: 5007
Joined: Wed Feb 14, 2007 5:14 pm
Location: UK

Re: 1255 View | (Track) Properties enabled on Tree node [685

Post by chrisjj »

> I don't think there is a confusion that Properties doesn't apply to tracks.

Certainly since that report the confusion has been reduced... by the elimination of the Properties command from most (all?) other elements.

If the View | Properties command really only shows track properties, confusion could be reduced by labelling it consistently with the dialog box title: "Track Properties".
Chris
Lowlander
Posts: 58631
Joined: Sat Sep 06, 2003 5:53 pm

Re: 1255 View | (Track) Properties enabled on Tree node [685

Post by Lowlander »

What I find most strange is that they are different dialogs. I recall when learning MM I "lost" the better one and had to ask here :)
Post Reply