Discogs Auto-tag Web Search

[eepman]

Oh, I think I may know the problem, and when I get home from work I can post the update, but I updated the XML parser to V6.0 from M$. You can download it from Micro$oft if you don't have it. Hope that helps your issues, I will make the next version backwards compatible.

Well I removed a large portion of the codebase that was extremely buggy, on my system it sped up no less than ten-fold and no loss of functionality. The search works a lot lot better, as in it gave me correct results. All of the timer code was completely unnecessary and only succeeded in slowing the script execution. I'm going to be doing a "full overhaul" after this one is quite stable, so then you'll really see the changes, such as per track tagging, getting rid of the multiple artist name numbering, more meta info tagging, fixing up the genre style bs, etc.

Let me know any suggestions you may have.

Download: Discogs Auto-Tag Web Script V1.44 (as of 8/7/09 9:00 am est)

Edit: this version (1.33) should fix the per track tagging and most other optional tagging. please report problems.
Edit: v1.34 minor changes
Edit: v1.44 added date patch below and search by release id/store releaseid in custom1 for quick tagging.

[Let]

It works now for the first search but when another result is selected from the dropdown it starts giving "error executing script event" and after a few seconds media monkey crashes. Would you also put back search by release id feature? (i.e. when you write release id and press search button, it loads the release directly without doing any search)

You might want to take a look at musicbrainz tagger script. Ihas so many nice features, like a setting window, logging features. I'm sure you'll get so many good ideas. Lastly, I'd suggest you to remove your discogs api key from your scripts otherwise your key might get invalid.

[eepman]

Those are all excellent points. I was rushing to get this one out. Next version will be clean and nice. Yeah sorry about taking out release ID, but it was just to make it easier on me to get the rest of the script up to speed. Hmm, I don't know what script event errors are caused by, but I remember I was able to get rid of them with a simple mediamonkey restart and they didnt come back. At the moment it seems some of the options don't take effect unless you close the tagging window and reopen it. All of these will be fixed in the next version, I guarantee.

[waku]

It's nice to see that this script is being developed since I use discogs a lot! I made some changes for 1.1.1 in the release date. Don't know if it will work with 1.34. Instead of just grabbing the release year I would rather have the full release day (if it exists). This is the first time programming in vbs, so please let me know if my methods are awkawd.

Find:

Code: Select all

' Get release year
Set itm = theRelease.selectSingleNode("released")
If Not (itm Is Nothing) Then
     If Len(itm.Text) > 3 Then
      ReleaseYear = Left(itm.Text, 4)
     Else
      ReleaseYear = ""
     End If
Else
     ReleaseYear = ""
End If

Replace with:

Code: Select all

' Get release year/date
Set itm = theRelease.selectSingleNode("released")
If Not (itm Is Nothing) Then
		If Len(itm.Text) > 7 Then
        ReleaseSplit = Split(itm.Text,"-")
			If ReleaseSplit(2) = "00" Then
				ReleaseYear = Left(itm.Text, 4)
			Else
          	ReleaseYear = ReleaseSplit(2) & "-" & ReleaseSplit(1) & "-" & ReleaseSplit(0)
			End if
		Else
			ReleaseYear = itm.Text
 End If
Else
      ReleaseYear = ""
End If

Since discogs shows the date as year-month-day (2009-08-04) I alter it to show day-month-year instead. This is a matter of taste of course.

Find:

Code: Select all

If ReleaseYear <> "" And CheckYear Then SDB.Tools.WebSearch.NewTracks.Item(i).Year = ReleaseYear

Replace with:

Code: Select all

If ReleaseYear <> "" And CheckYear Then
		  	If Len(ReleaseYear) > 4 Then
				SDB.Tools.WebSearch.NewTracks.Item(i).Date = ReleaseYear
			Else
				SDB.Tools.WebSearch.NewTracks.Item(i).Year = ReleaseYear
			End If	
End If

It works for me and I haven't noticed any errors. But when you are tagging the release date will not show up as a change (you know, when the background turns yellow) because only the year will be shown. When you save the tags, the full release date will however also be saved.

[eepman]

I'll patch in your date scripting thanks! I think that internally MM stores dates as DD/MM/YYYY, so I may format them that way instead. We'll see what works best. Expect a new version before the end of the week . Oh and Let, proper settings window is coming soon, and search by release id should only take a few minutes after I get home hopefully .

[Let]

It would be best to have dropdown boxes into settings page for each custom field (custom1, custom2..) to put some information (label, genre, style, genre + style, release id....) For example I've modified my script to put release id into custom 3 so that i can easily find discogs entry when i need it later (for re-tagging etc).

Looking forward for your updates..

[Anon]

Hi, Sorry, How Do I install this script (144?) I used to have this pluging working and can't live without it. It was the only way to tag my collection. I've read through the thread but still a little lost.

[eepman]

Hi, Sorry, How Do I install this script (144?) I used to have this pluging working and can't live without it. It was the only way to tag my collection. I've read through the thread but still a little lost.

Just copy it to your Scripts directory in the MediaMonkey main directory, and then open it in notepad to change the API Key to your own.
Should work after that ;D.

[Bart D]

Hi, Sorry, How Do I install this script (144?) I used to have this pluging working and can't live without it. It was the only way to tag my collection. I've read through the thread but still a little lost.

Hi,

it also did not work here from the start. What I did was:

1) install an older version of the script (ignore if it is already installed)
2) use the 1.44 txt file and fill in the api code, copy all the code
3) open the DiscogsAutoTagWeb.vbs file in the MM scripts dir using notepad or notepad +, paste the code and save
4) start labeling

Thx again for this great MM script

[Let]

I think your version works fine now. I'd be happy if you can include the patch below. This allows to type release id in the search box (after finding it in web browser) and after pressing search button it loads that release directly without searching. It's very handy if you have so many results and you know what release is your album and don't want to dig the results.

Code: Select all

  if IsNumeric(SearchTerm) Then
	Set Results = SDB.NewStringList
	Set FoundLinks = SDB.NewStringList

	Results.Add SearchTerm
	FoundLinks.Add "release/" & SearchTerm

	SDB.Tools.WebSearch.SetSearchResults Results
	SDB.Tools.WebSearch.ResultIndex = 0
  	Exit Sub
  end if

One last thing: I haven't seen your last change since you've edited your previous message. It'd be great if you can send new versions in a seperate message.

[eepman]

All new version 1.5 !!

check it out
DiscogsAutoTagWebScriptMagicWonderFunEdition1.5

added:
direct search by releaseid
removal of numbering after similarly named artists (that was annoying wasnt it? )
some other stuff most likely

tell me what you think!

[Let]

works perfect. a bug and a request...

bug: when genre dropdown is selected it doesn't reflect changes to results instantly. After changing the combo and closing the search window, reopening it brings new genres.

request: more information would be useful in search dropdown (label, country and year). as an example when i search "ace of base - all that she wants" i see 20 results in the search results combo box with the same text "ace of base - all that she wants". then i have to try each of them. mostly country and label is known. although year seems insignificant, it would help to differentiate remix/cover albums.

thank you again!

[Let]

oops! discogs xml api doesn't return year label etc. interesting part is that web search in their web site shows them!

i've request some additional info in search results in discogs forum. if they add those fields then we can use it!

i'll let you know.

[waku]

I've just got version 1.5 running, but I've noticed some major bugs. Of course I don't know if it's just my pc, but I've tried to both restart MM, uninstall/reinstall the script, restart the pc etc. Nothing solved the problem.

You want to tag some files, e.g. an album, but you dont want to tag the artistname because Discogs calls it "Artistname*" or "Artistname (2)" instead of just Artistname. When you untick it, nothing happens though. And you have the same problem if you left a field unticked from the latest search, but now you want to tag the artistname again. Nothing happens when you tick it.

I've tried to find the bug in the script - if it exists - but I'm new to vbs so debugging isn't easy And I didn't notice anything odd. Does anyone have the same problem as me?

Anyway, I do feel that the script is improved. Search speed is much faster and correct now!

[shanghai_ultra]

I have a suggestion. A lot of us (especially those into electronic music) like to know which label their tracks were published on.

I wonder if someone could map Discogs "label" field to "Publisher" field in the standard ID3v2 tag? Since there is no dedicated label field in the ID3v2 standard.

Possible?