Discogs Tagger 3.62 (Updated: 2013-02-09)

[Let]

you're welcome I hope you make use of it....

[robojock]

Does this work with mm4? i can't get mine to work, it gives me a error
"Error #53 - Microsoft VBScript runtime error
File not found
File: "C:\Users\Username\Appdata\Local\Temp\Mediamonkey\install.vbs" , Line: 36, Column: 3"

Please help

Thanks

[Let]

i'm sure it will work once mm4 gets released

[FuchiK]

http://www.filefactory.com/file/cb9e19c ... agWeb.mmip

link in case the download doesn't work for you.

[kazzy]

Hello. I have been using the script for a few days with no problems.

Now I just got the following error when trying to tag flac files.

Error #424 - Microsoft VBScript runtime error
Object required: 'XMLSearchResults'
File: "C:\Program Files (x86)\MediaMonkey\Scripts\DiscogsAutoTagWeb.vbs", Line: 544, Column: 3

Using MM Pro 3.2.5.1306 with Discogs Tagger 3.1 on Windows 7 64-bit SP1.

Thank you!

[Let]

do you have msxml6 installed?

[Let]

brown: are you promoting your site or is it me feeling that way?

[Let]

Discogs have announced that they will be releasing API v2.0 and closing out current API on Dec 15, 2011. We'll be using the current API for now and I'll be following the v2.0 and upgrade it at some point. Check the blog entry for more information:

http://blog.discogs.com/2011/06/api-v20.html

[DocMAX]

getting same error #424

[lrds]

#424 error as well

[Let]

I don't get this error. Since API 2.0 is being developed, it might be a temporary issue.

Line 544 is:

Code: Select all

ResultCount = XMLSearchResults.selectSingleNode("@numResults").Text

would you put this before this line, run the script again and post the text in the message box?

Code: Select all

msgbox searchURL

This might give us a clue.

[Eyal]

Mine stopped working too.

would you put this before this line, run the script again and post the text in the message box?

Code: Select all

msgbox searchURL

Thanks

[Let]

I've found the problem. when search string includes a minus sign '-', resulting xml becomes invalid. I've opened a thread on the API forum on discogs regarding this problem. For now avoid searching with minus sign. If they don't fix it, I'll add code for filtering minus sign. Searching in discogs is very messy.

[ihartley]

Hi, (don't shoot the newbie! )

I also had this problem, and thought it was to do with the '-'. The problem seems to be when zero results are returned; maybe they have changed the response but it then no longer returns a node (or whatever XML calls it) with the number of the search results returned. Instead it returns "None"

I changed the code to the following:

Code: Select all

'change lines 544-558
			If Not (XMLSearchResults is nothing) Then
				ResultCount = XMLSearchResults.selectSingleNode("@numResults").Text
				If ResultCount > 0 Then 
					Set AColl = XMLSearchResults.selectNodes("result")
	
					For Each itm In AColl
					if (itm.selectSingleNode("@type").text = "release" ) then
						Results.Add itm.selectSingleNode("summary").Text
						ResultsReleaseID.Add Mid(itm.selectSingleNode("uri").Text, InStrRev(itm.selectSingleNode("uri").Text, "/") + 1)
					End If
					Next
				End If

			End If

			If (ResultCount = 0) Then
				Results.Add SearchTerm &  " - [search returned no results]"
				ResultsReleaseID.Add SearchTerm
				ErrorMessage = "Search returned no results"
			End If

Bear in mind the last time I wrote code C++ was only just appearing on the horizon! (and no, I'm not old enough to have coded in B ). This works for me anyway - Discogs is my favourite tagger and I love this script, but it does seem that a bit of extra work is required to make the script sing (e.g. I'd love an option to list results only with the right number of tracks!). I have also done a couple of personal mods : replaced FilterMediaType = "None" with "CD Album" so that is the default option of the results filter, removed almost all of the countries, etc.

Hope that works for y'all. I'm not sure how the valuable efforts of the script writers are organised, but as a newbie it seems very haphazard in terms of quality, effort, etc. (My whole library has been tagged with this script, hence my shock that it didn't work!). It would be great if the core team could organise development as a light "open source" project - the scripting is such a powerful feature of MM, and a primary reason for my move from iTunes (apart from my love/hate relationship with SJ).

[lrds]

This little fix works for now. Thanks!!