RC1: Album Art injecting into tags inappropriately [F3913]

[KEP]

Using RC1, I'm convinced the whole Album Art thing is still royally whacked out. I haven't found any logical consistency since I started playing with B2.

To add album art, I frequently do this:

* select all the tracks of an album (sidenote: this step wasn't necessary in MM2),
* drag an image that's already in the album's folder into the Album Art preview.

If I have all three "Image location" checkboxes unchecked, MM3RC1 is writing the image into the MP3 files themselves. I feel this is a bug, although some might find it somewhat consistent because "where else should it store it?" Bzzzzt!

If I simply select "Link to image file", that seems to work best, although in many situations (which I haven't reliably reproduced yet), I end up with a second track listed for each existing track in the album. Other times, the image simply doesn't show up, in the preview or the right-click menu or the Album Art properties sheet. It's as if I was totally ignored.

It's extremely irritating, as well, that "Save image to album folder" is always checked. No matter what. First, that choice should be persisted from one invocation of this dialog to the next. Second, the image is already in the album art folder! All kinds of messes occur if you forget to uncheck that.

But back to the point of this bug report, why, oh why, is the image written into the MP3 file if "Save image to tag (if possible)" is left unchecked??? That's a very serious bug.

Obviously, to me at any rate, if none of the three "Image location" checkboxes are checked, the default behavior should be to link to the image where it exists. Right? In fact, I'd go so far as to suggest that the 1st and 3rd checkboxes should be mutually exclusive option buttons, and only the 2nd checkbox should be optional.

I am truly afraid to check that "In the future, do not ask me" option. This dialog needs some very rigorous regression testing. Default behaviors for Album Art need to be documented and followed.

Thanks...

[rusty]

Thx. You're right--there is a bug that Art is saved even when no option is checked off for saving Art. I also agree with you that the better approach (that would avoid this entirely) would be to modify the UI slightly to:

(o) Save image to tag (if possible)
( ) Link to image file
[ ] Save image to album folder
. . . _folder.jpg_____________

We'll either fix the bug and defer the UI fix, or tackle the UI right away.

As far as the complaint that a default option shouldn't always be checked off, the default option is configurable in Tools > Options > Tags and Playlists > Album Art > Image location . I felt that it would be better to have it configurable than to persist this based on last used configuration, but would be glad to listen to another opinion (keep in mind that the implementation has to support a 'do not ask me' option).

-Rusty

[KEP]

Hi Rusty --

Thx. You're right--there is a bug that Art is saved even when no option is checked off for saving Art.

Alright, I finally got a repro.

I also agree with you that the better approach (that would avoid this entirely) would be to modify the UI slightly to:

(o) Save image to tag (if possible)
( ) Link to image file
[ ] Save image to album folder
. . . _folder.jpg_____________

We'll either fix the bug and defer the UI fix, or tackle the UI right away.

Much better design, yes.

As far as the complaint that a default option shouldn't always be checked off, the default option is configurable in Tools > Options > Tags and Playlists > Album Art > Image location.

True, but that's missing at least two choices - Link to image, and None of the Above. <g>

I felt that it would be better to have it configurable than to persist this based on last used configuration, but would be glad to listen to another opinion (keep in mind that the implementation has to support a 'do not ask me' option).

I suppose if it had all available options, then this would be viable. I don't see a contradiction with having a "Do not ask me" checkbox altering the configured setting, though? That seems entirely consistent with honoring the user's expressed desire.

There's another issue here, too. I originally set that option thinking it would be what's used when you save Album Art from a source such as Amazon. I can easily see someone (me!) having two distinct desires here. For example, 1) "save to album folder" when downloaded, and 2) "link to image" when adding through the Album Art properties dialog or (especially!) when dragged in from Explorer. Given these different ways of using this feature, it seems a single hard-coded method isn't as flexible as one that remembers the last usage.

Thanks...

[rusty]

RC-2 is fixed so that if none of the options is checked off, Art isn't saved to tags.

We thought about modifying the UI along the lines you described (mutually exclusive Tag vs Link options) but decided not to since some users apparently want to save art to _both_ locations. See:
http://www.mediamonkey.com/forum/viewtopic.php?t=15964
http://www.mediamonkey.com/forum/viewtopic.php?t=5613

-Rusty

[KEP]

RC-2 is fixed so that if none of the options is checked off, Art isn't saved to tags.

We thought about modifying the UI along the lines you described (mutually exclusive Tag vs Link options) but decided not to since some users apparently want to save art to _both_ locations.
-Rusty

Good news on the bug fix.

But I sure don't understand the UI concern. What we talked about would allow saving to both places, by simply checking the button "Save image to album folder."

I see no suggestion at all, from the links you posted, that anyone would want to both embed an image within an MP3 and link to it on disk. What purpose would that serve?

Thanks...

[Teknojnky]

I want to both save image to tag AND save/link to file.

Because embedded album art always tends to 'disappear' randomly etc.

[KEP]

I want to both save image to tag AND save/link to file.

Because embedded album art always tends to 'disappear' randomly etc.

So you basically want to do all three options, then? I mean, why would you want to have two identical images offered, when you right-click on the Album Art preview? If the first (presumably the embedded one?) became unavailable, it'd just blank out and you'd have to right-click/select to see the linked one. If the first were the linked one, and it got trashed somehow, same thing. I guess I just don't see any real savings having them set up that way.

(I agree, the album art features are still very flaky.)

[Teknojnky]

The primary reason is so that I can re-embed the saved (linked) image and I can ensure I keep the same consistent image, instead of having re-search/download a different, possibly more or less quality image.

Aside from that, some users portable mp3 players only support embeded, or oonly support linked art. Having both assures that art should be available regardless.

In any case, it comes down to A) personal preference, B) flexibility.

[KEP]

Certainly understand wanting to keep an un-embedded copy of the graphic on file, as I do the need for both personal preferences and flexibility! Just don't understand the rationale of wanting two associated copies of the same bits within this (MM3) database. I feel like I'm not communicating very well, as the point I'm trying to raise isn't being addressed directly. Could be I'm just not hearing very well. <shrug>