Edit Playcount Properties [#22247]

[fetzenschaedl]

Hello,
While testing an addon, i noticed that if you edit the playcount via Properties/Details tab MM always adds a played entry to the database, even when the playcount is decreased or set to zero.
For Example, song has zero plays, adjusting the playcount to 1 will add a played entry to the database and the lastplayeddate will be set. Setting the playcount to zero again removes the lastplayeddate but it adds another played entry to database.
I am not sure if this is intended behaviour.

Version is 2024.2.2.3222

[Peke]

Hi,
I can't replicate your issue of MM adding Played and playcount on its own.

See Video https://drive.google.com/file/d/1ofrGNm ... drive_link

If I do wrong something can you please point in my video where you observe that issue?

NOTE: I do not have any addon that temper with Playcounts to keep MM design behavior only.

[Peke]

Hi,
First I would like to thank you for porting MM4 plugin, but it too much interfere with playcounts, that user data like you described here can be can be risky to use.

Please let us know how we can help you with hammering down the possible issues and make it work better or if you have found issue in our API please point us to them so that they can be fixed on mutual benefit.

[fetzenschaedl]

Hello,

unfortunately I couldn't access your video. Also the issue is not really with the addon I submitted, which just made me notice the behaviour while testing the remove plays function. But I understand the concerns about data loss when not used properly. Let me try to explain better:

I start with song "aaa", artist "bbb", never played, zero playcounts



Then I put the following into the sql editor

Code: Select all

SELECT
    Songs.SongTitle,
    Songs.Artist,
    Songs.PlayCounter,
    datetime(
        (Songs.LastTimePlayed - 25569) * 86400,
        'unixepoch',
        'localtime'
    ) AS LastPlayed,

    datetime(
        (Played.PlayDate - 25569) * 86400,
        'unixepoch',
        'localtime'
    ) AS PlayDate

FROM Songs
LEFT JOIN Played
    ON Songs.ID = Played.IdSong
WHERE Songs.SongTitle = 'aaa'
  AND Songs.Artist = 'bbb'
ORDER BY Played.PlayDate DESC;

Which will result in



Then I open the properties dialog, and set the play counter to 1 in the details tab



which leads to



everything as expected so far, playcounter, LastTimePlayed and PlayDate are updated. However if I set the play counter back to zero in the properties/details tab



I end up with



so the PlayCounter and the LastTimePlayed Tables get reset as I expected, the PlayDate however does not. It seems to me that Mediamonkey always adds an entry to the PlayDate everytime the Playcounter is edited by the Properties/Details dialog, regardless if the playcounter is increased, decreased or set to zero. So I don't know if this behaviour is intentional or not.

MM 2024.2.2.3222

[Ludek]

Hi,
good catch, entered as https://www.ventismedia.com/mantis/view.php?id=22247