1357: MM4 localization issues (updated)

[gege]

In "ExportOPML.vbs" script, the following line:

Code: Select all

title = "My podcasts"

...should be replaced by:

Code: Select all

title = SDB.Localize("My podcasts")

Note: string "My podcasts" is already reported in issue 7546, item #7, to be included in default.po.

[FIXED]

[gege]

Here is a review of remaining localization issues mentioned in http://www.ventismedia.com/mantis/view.php?id=7546
All of them are said to be fixed, but from what I could verify, they aren't.

1) Missing Strings:
a) Tracks added within 30 days (in playlists node) . Change to 'Recently Added'.

[FIXED].

2) Missing Tooltip Strings:
a) Library > Generate thumbnails for videos
--> Generates thumbnails automatically for videos that don't have any artwork.

[FIXED]

3) Misc. Capitalization issues:
a) audio CD appears in numerous spots instead of 'Audio CD'

[NOT FIXED]There are still two occurences of 'audio CD'. In fact these strings are duplicated with both capitalizations: 'Buy audio CDs at CDUniverse', 'Buy audio CDs at Amazon'.

4) Translated string that doesn't appear in UI
a) File list (HTML) (from report menu--the db.po file has Track list (html), and seems to not have been updated)

[FIXED]

5) Add scan dialog is too narrow--it causes translated 'Scan continuously' and 'Scan at Startup' text to wrap.

[FIXED]

7) Missing Script-related Strings:
# Script: Case Checker
msgid "Old Value: "
msgstr ""
...

[FIXED]

Not Localizable:
- Script: Create Reports > Statistics
Resulting date in footer is printed always in english form, it's not localized.

[Won't be FIXED]

9) Misc. non-functional fixes to .po files:
'Auto DJ' string still exists (despite the fact that 'Auto-DJ' displays correctly in the UI)

[FIXED]

[gege]

The Export.vbs script is still missing some localization.
[FIXED] Strings are now localizable. They only need to be updated in localization catalog.

The following lines need to be changed:

Code: Select all

Line #104:
Call InitExport (".csv", "CSV (*.csv)|*.csv|All files (*.*)|*.*", _
---->  Call InitExport (".csv", SDB.Localize("CSV (*.csv)|*.csv|All files (*.*)|*.*"), _

Line #181:
Call InitExport( ".htm", "HTML (*.htm)|*.htm|All files (*.*)|*.*", _ 
---->  Call InitExport( ".htm", SDB.Localize("HTML (*.htm)|*.htm|All files (*.*)|*.*"), _

Line #378:
Call InitExport( ".xls", "Excel sheet (*.xls)|*.xls|All files (*.*)|*.*", _
---->  Call InitExport( ".xls", SDB.Localize("Excel sheet (*.xls)|*.xls|All files (*.*)|*.*"), _

Line #482:
Call InitExport (".xml", "XML (*.xml)|*.xml|All files (*.*)|*.*", _
---->  Call InitExport (".xml", SDB.Localize("XML (*.xml)|*.xml|All files (*.*)|*.*"), _

Line #395:
MsgBox "Microsoft Excel could not be found, please install it and try again.
---->  MsgBox SDB.Localize("Microsoft Excel could not be found, please install it and try again.")

And then these strings need to be added to "Default.po":

Code: Select all

msgid "CSV (*.csv)|*.csv|All files (*.*)|*.*"
msgstr ""

msgid "HTML (*.htm)|*.htm|All files (*.*)|*.*"
msgstr ""

msgid "Excel sheet (*.xls)|*.xls|All files (*.*)|*.*"
msgstr ""

msgid "XML (*.xml)|*.xml|All files (*.*)|*.*"
msgstr ""

msgid "Microsoft Excel could not be found, please install it and try again."
msgstr ""

[gege]

There're some strings used in Script.ini, which weren't updated in db.po. [FIXED]

Replace these strings...

Code: Select all

msgid "Track List (CS&V)"
msgstr ""

msgid "Exports selected tracks to a .csv file"
msgstr ""

msgid "Track List (&XML)"
msgstr ""

msgid "Exports selected tracks to an .xml file"
msgstr ""

msgid "Track List (&HTML)"
msgstr ""

msgid "Exports selected tracks to a .htm file"
msgstr ""

msgid "Track List (&Excel)"
msgstr ""

msgid "Exports selected tracks to a .xls file"
msgstr ""

msgid "Sequentially numbers Tracks"
msgstr ""

...with these:

Code: Select all

msgid "File List (CS&V)"
msgstr ""

msgid "Exports list of selected files to a .csv file"
msgstr ""

msgid "File List (&XML)"
msgstr ""

msgid "Exports list of selected files to an .xml file"
msgstr ""

msgid "File List (&HTML)"
msgstr ""

msgid "Exports list of selected files to an .htm file"
msgstr ""

msgid "File List (&Excel)"
msgstr ""

msgid "Exports list of selected files to a .xls file"
msgstr ""

msgid "Sequentially numbers files"
msgstr ""

[PetrCBR]

gege,

re 1: in clear install, Recently Added playlist will be created instead of 'Tracks added within 30 days'. Also non of the predefined playlists are localized.
re 2: fixed in 1358
re 3: wait for updated catalog
re 5: fixed in 1358
re 8: what windows language do you have ? It can be related to this (as this text is generated by Windows).

[gege]

re 8: what windows language do you have ? It can be related to this (as this text is generated by Windows).

My windows is in pt-br locale.

[gege]

While investigating this issue AND this, I discovered a new related one, regarding scripts.ini: [FIXED]

If we do a clean install, script entries/descriptions in scripts.ini are the new ones, referencing 'files', just like this:

Code: Select all

"File List (CS&V)"
"Exports list of selected files to a .csv file"
"File List (&XML)"
"Exports list of selected files to an .xml file"
"File List (&HTML)"
"Exports list of selected files to an .htm file"
"File List (&Excel)"
"Exports list of selected files to a .xls file"
"Sequentially numbers files"

But, if we do an upgrade, then script entries/description fields are not updated, and thus all strings refer to 'tracks', like this:

Code: Select all

"Track List (CS&V)"
"Exports selected tracks to a .csv file"
"Track List (&XML)"
"Exports selected tracks to an .xml file"
"Track List (&HTML)"
"Exports selected tracks to a .htm file"
"Track List (&Excel)"
"Exports selected tracks to a .xls file"
"Sequentially numbers Tracks"

These fields should be always updated, no matter if it's a clean install or an upgrade.

[jiri]

Thanks, fixed in the next build.

Jiri

[gege]

I have just revised all remaining issues, and as of build 1361 all that's left are these:

3) Misc. Capitalization issues:
a) audio CD appears in numerous spots instead of 'Audio CD'

[NOT FIXED]There are still two occurences of 'audio CD'. In fact these strings are duplicated with both capitalizations: 'Buy audio CDs at CDUniverse'/'Buy Audio CDs at CDUniverse', 'Buy audio CDs at Amazon'/'Buy Audio CDs at Amazon'.

Not Localizable:
- Script: Create Reports > Statistics
Resulting date in footer is printed always in english form, it's not localized.

[Won't be FIXED, so it's fine]